From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0
Date: Thu, 24 Jul 2014 14:48:57 +0200 [thread overview]
Message-ID: <20140724124857.GX20328@lukather> (raw)
In-Reply-To: <1405358677-23657-3-git-send-email-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Tue, Jul 15, 2014 at 01:24:37AM +0800, Chen-Yu Tsai wrote:
> The pinctrl-sunxi driver originally used the pin number as the gpio
> range offset. This resulted in large, bogus gpio numbers for the
> new sun6i-a31-r pinctrl devices.
>
> This patch makes the driver number the gpios ranges starting from an
> offset of 0, by subtracting the pin_base number from the pin number.
> This also makes the system-wide gpio number match the pin number.
>
> Tested on sun8i with sysfs exported gpios.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0
Date: Thu, 24 Jul 2014 14:48:57 +0200 [thread overview]
Message-ID: <20140724124857.GX20328@lukather> (raw)
In-Reply-To: <1405358677-23657-3-git-send-email-wens@csie.org>
On Tue, Jul 15, 2014 at 01:24:37AM +0800, Chen-Yu Tsai wrote:
> The pinctrl-sunxi driver originally used the pin number as the gpio
> range offset. This resulted in large, bogus gpio numbers for the
> new sun6i-a31-r pinctrl devices.
>
> This patch makes the driver number the gpios ranges starting from an
> offset of 0, by subtracting the pin_base number from the pin number.
> This also makes the system-wide gpio number match the pin number.
>
> Tested on sun8i with sysfs exported gpios.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140724/3c18f510/attachment.sig>
next prev parent reply other threads:[~2014-07-24 12:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 17:24 [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio Chen-Yu Tsai
2014-07-14 17:24 ` Chen-Yu Tsai
[not found] ` <1405358677-23657-1-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-07-14 17:24 ` [PATCH 1/2] pinctrl: sunxi: use gpiolib API to mark a GPIO used as an IRQ Chen-Yu Tsai
2014-07-14 17:24 ` Chen-Yu Tsai
2014-07-24 11:46 ` Maxime Ripard
2014-07-24 11:46 ` Maxime Ripard
2014-07-28 10:11 ` Linus Walleij
2014-07-28 10:11 ` Linus Walleij
2014-07-14 17:24 ` [PATCH 2/2] pinctrl: sunxi: number gpio ranges starting from 0 Chen-Yu Tsai
2014-07-14 17:24 ` Chen-Yu Tsai
2014-07-24 12:48 ` Maxime Ripard [this message]
2014-07-24 12:48 ` Maxime Ripard
[not found] ` <1405358677-23657-3-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2014-07-24 13:19 ` Chen-Yu Tsai
2014-07-24 13:19 ` Chen-Yu Tsai
[not found] ` <CAGb2v64mZjmB+ftQ7yM5LzhUyPVGtCXq6DOUQ-pumLb73_DYLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-24 16:01 ` Maxime Ripard
2014-07-24 16:01 ` Maxime Ripard
2014-07-24 16:17 ` Chen-Yu Tsai
2014-07-24 16:17 ` Chen-Yu Tsai
2014-07-28 10:14 ` Linus Walleij
2014-07-28 10:14 ` Linus Walleij
2014-07-22 16:33 ` [PATCH 0/2] pinctrl: sunxi: misc improvements for gpio Linus Walleij
2014-07-22 16:33 ` Linus Walleij
[not found] ` <CACRpkdZhZkB6=_ehVXxWAnvkVYy_KOU84fcGRSRTc9-2X2paqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-24 12:57 ` Maxime Ripard
2014-07-24 12:57 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724124857.GX20328@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.