From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx-drm: imx-drm-core: add suspend/resume support
Date: Fri, 25 Jul 2014 14:34:38 +0800 [thread overview]
Message-ID: <20140725063437.GG8821@dragon> (raw)
In-Reply-To: <53D0D850.8050201@pengutronix.de>
On Thu, Jul 24, 2014 at 11:56:32AM +0200, Marc Kleine-Budde wrote:
> >> @@ -696,6 +696,44 @@ static int imx_drm_platform_remove(struct platform_device *pdev)
> >> return 0;
> >> }
> >>
> >> +#if CONFIG_PM_SLEEP
> >
> > use #ifdef
>
> ...or remove #if/#ifdef and mark as __maybe_unused
I personally do not like the idea of __maybe_unused. Will there be a
compile error if I call some helper functions which are only available
with CONFIG_PM_SLEEP?
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawn.guo@freescale.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Russell King <linux@arm.linux.org.uk>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org,
Lucas Stach <l.stach@pengutronix.de>
Subject: Re: [PATCH] imx-drm: imx-drm-core: add suspend/resume support
Date: Fri, 25 Jul 2014 14:34:38 +0800 [thread overview]
Message-ID: <20140725063437.GG8821@dragon> (raw)
In-Reply-To: <53D0D850.8050201@pengutronix.de>
On Thu, Jul 24, 2014 at 11:56:32AM +0200, Marc Kleine-Budde wrote:
> >> @@ -696,6 +696,44 @@ static int imx_drm_platform_remove(struct platform_device *pdev)
> >> return 0;
> >> }
> >>
> >> +#if CONFIG_PM_SLEEP
> >
> > use #ifdef
>
> ...or remove #if/#ifdef and mark as __maybe_unused
I personally do not like the idea of __maybe_unused. Will there be a
compile error if I call some helper functions which are only available
with CONFIG_PM_SLEEP?
Shawn
next prev parent reply other threads:[~2014-07-25 6:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 9:17 [PATCH] imx-drm: imx-drm-core: add suspend/resume support Shawn Guo
2014-07-24 9:17 ` Shawn Guo
2014-07-24 9:38 ` Philipp Zabel
2014-07-24 9:38 ` Philipp Zabel
2014-07-25 6:31 ` Shawn Guo
2014-07-25 6:31 ` Shawn Guo
2014-07-24 9:47 ` Lucas Stach
2014-07-24 9:47 ` Lucas Stach
2014-07-24 9:54 ` Russell King - ARM Linux
2014-07-24 9:54 ` Russell King - ARM Linux
2014-07-24 10:38 ` Daniel Vetter
2014-07-24 10:38 ` Daniel Vetter
2014-07-24 14:59 ` Shawn Guo
2014-07-24 14:59 ` Shawn Guo
2014-07-25 8:20 ` Daniel Vetter
2014-07-25 8:20 ` Daniel Vetter
2014-07-24 9:56 ` Marc Kleine-Budde
2014-07-24 9:56 ` Marc Kleine-Budde
2014-07-25 6:34 ` Shawn Guo [this message]
2014-07-25 6:34 ` Shawn Guo
2014-07-25 5:46 ` Shawn Guo
2014-07-25 5:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725063437.GG8821@dragon \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.