All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, b42378@freescale.com,
	timur@tabi.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, tiwai@suse.de,
	linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	b02247@freescale.com, lgirdwood@gmail.com, robh+dt@kernel.org,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	broonie@kernel.org, galak@codeaurora.org,
	grant.likely@linaro.org, tklauser@distanz.ch,
	shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 16:42:50 +0800	[thread overview]
Message-ID: <20140725084249.GB29564@MrMyself> (raw)
In-Reply-To: <53D2189E.4030108@gmail.com>

On Fri, Jul 25, 2014 at 02:13:10PM +0530, Varka Bhadram wrote:
> On 07/25/2014 01:27 PM, Nicolin Chen wrote:
> >>>+	if (IS_ERR(asrc_priv->regmap)) {
> >>>+		dev_err(&pdev->dev, "failed to init regmap\n");
> >>>+		return PTR_ERR(asrc_priv->regmap);
> >>>+	}
> >>>+
> >>>+	irq = platform_get_irq(pdev, 0);
> >>>+	if (irq < 0) {
> >>>+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
> >>>+		return irq;
> >>>+	}
> >>>+
> >>>+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
> >>>+			       asrc_priv->name, asrc_priv);
> >>same...
> >Sorry I don't see any problem with this devm_request_irq()...
> 
> Ohhh... This is the problem with my email client... Sorry...

No problem. I appreciate your carefulness :)

Thank you,
Nicolin

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, b42378@freescale.com,
	timur@tabi.org, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, tiwai@suse.de,
	linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	b02247@freescale.com, lgirdwood@gmail.com, robh+dt@kernel.org,
	perex@perex.cz, Nicolin Chen <nicoleotsuka@gmail.com>,
	broonie@kernel.org, galak@codeaurora.org,
	grant.likely@linaro.org, tklauser@distanz.ch,
	shawn.guo@linaro.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 16:42:50 +0800	[thread overview]
Message-ID: <20140725084249.GB29564@MrMyself> (raw)
In-Reply-To: <53D2189E.4030108@gmail.com>

On Fri, Jul 25, 2014 at 02:13:10PM +0530, Varka Bhadram wrote:
> On 07/25/2014 01:27 PM, Nicolin Chen wrote:
> >>>+	if (IS_ERR(asrc_priv->regmap)) {
> >>>+		dev_err(&pdev->dev, "failed to init regmap\n");
> >>>+		return PTR_ERR(asrc_priv->regmap);
> >>>+	}
> >>>+
> >>>+	irq = platform_get_irq(pdev, 0);
> >>>+	if (irq < 0) {
> >>>+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
> >>>+		return irq;
> >>>+	}
> >>>+
> >>>+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
> >>>+			       asrc_priv->name, asrc_priv);
> >>same...
> >Sorry I don't see any problem with this devm_request_irq()...
> 
> Ohhh... This is the problem with my email client... Sorry...

No problem. I appreciate your carefulness :)

Thank you,
Nicolin

WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>, <broonie@kernel.org>,
	<robh+dt@kernel.org>, <pawel.moll@arm.com>,
	<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<galak@codeaurora.org>, <rdunlap@infradead.org>,
	<lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.de>,
	<timur@tabi.org>, <grant.likely@linaro.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<alsa-devel@alsa-project.org>, <linuxppc-dev@lists.ozlabs.org>,
	<shawn.guo@linaro.org>, <b02247@freescale.com>,
	<b42378@freescale.com>, <tklauser@distanz.ch>
Subject: Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
Date: Fri, 25 Jul 2014 16:42:50 +0800	[thread overview]
Message-ID: <20140725084249.GB29564@MrMyself> (raw)
In-Reply-To: <53D2189E.4030108@gmail.com>

On Fri, Jul 25, 2014 at 02:13:10PM +0530, Varka Bhadram wrote:
> On 07/25/2014 01:27 PM, Nicolin Chen wrote:
> >>>+	if (IS_ERR(asrc_priv->regmap)) {
> >>>+		dev_err(&pdev->dev, "failed to init regmap\n");
> >>>+		return PTR_ERR(asrc_priv->regmap);
> >>>+	}
> >>>+
> >>>+	irq = platform_get_irq(pdev, 0);
> >>>+	if (irq < 0) {
> >>>+		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
> >>>+		return irq;
> >>>+	}
> >>>+
> >>>+	ret = devm_request_irq(&pdev->dev, irq, fsl_asrc_isr, 0,
> >>>+			       asrc_priv->name, asrc_priv);
> >>same...
> >Sorry I don't see any problem with this devm_request_irq()...
> 
> Ohhh... This is the problem with my email client... Sorry...

No problem. I appreciate your carefulness :)

Thank you,
Nicolin


  reply	other threads:[~2014-07-25  8:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  7:19 [PATCH v4 0/2] Add Freescale ASRC driver Nicolin Chen
2014-07-25  7:19 ` Nicolin Chen
2014-07-25  7:19 ` Nicolin Chen
2014-07-25  7:19 ` [PATCH v4 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma Nicolin Chen
2014-07-25  7:19   ` Nicolin Chen
2014-07-25  7:19   ` Nicolin Chen
2014-07-25  7:19 ` [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Nicolin Chen
2014-07-25  7:19   ` Nicolin Chen
2014-07-25  7:19   ` Nicolin Chen
     [not found]   ` <69b75ae4b0335cd3c9bedad67f57aaba13c0048c.1406271541.git.nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-25  7:35     ` Varka Bhadram
2014-07-25  7:35       ` Varka Bhadram
2014-07-25  7:35       ` Varka Bhadram
     [not found]       ` <53D208A9.3040903-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-25  7:57         ` Nicolin Chen
2014-07-25  7:57           ` Nicolin Chen
2014-07-25  7:57           ` Nicolin Chen
2014-07-25  8:43           ` Varka Bhadram
2014-07-25  8:43             ` Varka Bhadram
2014-07-25  8:42             ` Nicolin Chen [this message]
2014-07-25  8:42               ` Nicolin Chen
2014-07-25  8:42               ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725084249.GB29564@MrMyself \
    --to=guangyu.chen@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=b02247@freescale.com \
    --cc=b42378@freescale.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=rdunlap@infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=timur@tabi.org \
    --cc=tiwai@suse.de \
    --cc=tklauser@distanz.ch \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.