All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: "linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
	Richard Guy Briggs <rgb@redhat.com>,
	Will Deacon <Will.Deacon@arm.com>, Eric Paris <eparis@redhat.com>,
	"linux-audit@redhat.com" <linux-audit@redhat.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: audit: Fix build for audit changes
Date: Fri, 25 Jul 2014 10:21:09 +0100	[thread overview]
Message-ID: <20140725092108.GB24268@arm.com> (raw)
In-Reply-To: <20140724191237.GM17528@sirena.org.uk>

On Thu, Jul 24, 2014 at 08:12:37PM +0100, Mark Brown wrote:
> On Thu, Jul 17, 2014 at 12:26:42PM +0100, Mark Brown wrote:
> > From: Mark Brown <broonie@linaro.org>
> > 
> > Commit 3efe33f5d2 (audit: x86: drop arch from __audit_syscall_entry()
> > interface) removed the arch parameter from __audit_syscall_entry() and
> > updated the only current user in mainline but this breaks the ARMv8 audit
> > code that has been added in -next. Fix this by making the equivalent
> > update to ARMv8.
> 
> This is still broken -next.

It should now be temporarily fixed for the defconfig
(CONFIG_AUTIDSYSCALL disabled). I'm reluctant to merge the audit tree in
the arm64 tree as (a) I haven't seen a confirmation that this branch is
stable and will go upstream as is and (b) there are x86 changes without
Acks from the x86 maintainers (whether needed or not, I can't say).

So my temporary patch is some #ifndef's around the offending code. It
will be reverted and your patch applied once the audit tree meets the
arm64 tree.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: audit: Fix build for audit changes
Date: Fri, 25 Jul 2014 10:21:09 +0100	[thread overview]
Message-ID: <20140725092108.GB24268@arm.com> (raw)
In-Reply-To: <20140724191237.GM17528@sirena.org.uk>

On Thu, Jul 24, 2014 at 08:12:37PM +0100, Mark Brown wrote:
> On Thu, Jul 17, 2014 at 12:26:42PM +0100, Mark Brown wrote:
> > From: Mark Brown <broonie@linaro.org>
> > 
> > Commit 3efe33f5d2 (audit: x86: drop arch from __audit_syscall_entry()
> > interface) removed the arch parameter from __audit_syscall_entry() and
> > updated the only current user in mainline but this breaks the ARMv8 audit
> > code that has been added in -next. Fix this by making the equivalent
> > update to ARMv8.
> 
> This is still broken -next.

It should now be temporarily fixed for the defconfig
(CONFIG_AUTIDSYSCALL disabled). I'm reluctant to merge the audit tree in
the arm64 tree as (a) I haven't seen a confirmation that this branch is
stable and will go upstream as is and (b) there are x86 changes without
Acks from the x86 maintainers (whether needed or not, I can't say).

So my temporary patch is some #ifndef's around the offending code. It
will be reverted and your patch applied once the audit tree meets the
arm64 tree.

-- 
Catalin

  reply	other threads:[~2014-07-25  9:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 11:26 [PATCH] arm64: audit: Fix build for audit changes Mark Brown
2014-07-17 11:26 ` Mark Brown
2014-07-17 11:59 ` Catalin Marinas
2014-07-17 11:59   ` Catalin Marinas
2014-07-17 14:50   ` Mark Brown
2014-07-17 14:50     ` Mark Brown
2014-07-17 14:58     ` Catalin Marinas
2014-07-17 14:58       ` Catalin Marinas
2014-07-17 15:01       ` Mark Brown
2014-07-17 15:01         ` Mark Brown
2014-07-17 16:26 ` Richard Guy Briggs
2014-07-17 16:26   ` Richard Guy Briggs
2014-07-24 19:12 ` Mark Brown
2014-07-24 19:12   ` Mark Brown
2014-07-25  9:21   ` Catalin Marinas [this message]
2014-07-25  9:21     ` Catalin Marinas
2014-07-25 11:04     ` Mark Brown
2014-07-25 11:04       ` Mark Brown
2014-08-11  9:09 ` Will Deacon
2014-08-11  9:09   ` Will Deacon
2014-08-11 13:22   ` Eric Paris
2014-08-11 13:22     ` Eric Paris
2014-08-11 13:33     ` Will Deacon
2014-08-11 13:33       ` Will Deacon
2014-08-11 15:15       ` Catalin Marinas
2014-08-11 15:15         ` Catalin Marinas
2014-08-11 15:47         ` Will Deacon
2014-08-11 15:47           ` Will Deacon
  -- strict thread matches above, loose matches on Subject: below --
2014-08-17 14:26 Mark Brown
2014-08-17 14:26 ` Mark Brown
2014-08-18 16:40 ` Catalin Marinas
2014-08-18 16:40   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725092108.GB24268@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=broonie@kernel.org \
    --cc=eparis@redhat.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.