All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller
Date: Fri, 25 Jul 2014 18:42:17 +0530	[thread overview]
Message-ID: <20140725131217.GS8181@intel.com> (raw)
In-Reply-To: <1405626376-471-1-git-send-email-maxime.ripard@free-electrons.com>

On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote:
> Hi,
> 
> This patchset adds support for the DMA controller found in the
> Allwinner A31 and A23 SoCs.
> 
> This has been tested using the newly introduced SPI driver on an A31
> EVK. Support for DMA-driven SPI transfers will be the subject of
> another patch serie.
> 
> This has been around for around 5 monthes now, and didn't get any
> review but nitpicks for three versions, so I feel like it could be
> merged quite quickly.
I have applied this now.

Can you please send follow patches for these:
- don't recall if I pointed earlier, but can we use direct conversion for
  calculating convert_burst() and convert_buswidth(), latter one at least
  seem doable
- don't use devm_request_irq(). You have irq enabled and you have killed
  tasklet. This is too racy. You need to ensure no irqs can be generated before killing
  tasklets.
- use synchronize_irq() before killing tasklet

Thanks

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@googlegroups.com, kevin.z.m.zh@gmail.com,
	sunny@allwinnertech.com, shuge@allwinnertech.com,
	zhuzhenhua@allwinnertech.com, Arnd Bergmann <arnd@arndb.de>,
	andriy.shevchenko@intel.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller
Date: Fri, 25 Jul 2014 18:42:17 +0530	[thread overview]
Message-ID: <20140725131217.GS8181@intel.com> (raw)
In-Reply-To: <1405626376-471-1-git-send-email-maxime.ripard@free-electrons.com>

On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote:
> Hi,
> 
> This patchset adds support for the DMA controller found in the
> Allwinner A31 and A23 SoCs.
> 
> This has been tested using the newly introduced SPI driver on an A31
> EVK. Support for DMA-driven SPI transfers will be the subject of
> another patch serie.
> 
> This has been around for around 5 monthes now, and didn't get any
> review but nitpicks for three versions, so I feel like it could be
> merged quite quickly.
I have applied this now.

Can you please send follow patches for these:
- don't recall if I pointed earlier, but can we use direct conversion for
  calculating convert_burst() and convert_buswidth(), latter one at least
  seem doable
- don't use devm_request_irq(). You have irq enabled and you have killed
  tasklet. This is too racy. You need to ensure no irqs can be generated before killing
  tasklets.
- use synchronize_irq() before killing tasklet

Thanks

-- 

  parent reply	other threads:[~2014-07-25 13:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17 19:46 [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-07-17 19:46 ` Maxime Ripard
2014-07-17 19:46 ` [PATCH v11 1/2] Documentation: dt: Add Allwinner A31 DMA controller bindings Maxime Ripard
2014-07-17 19:46   ` Maxime Ripard
2014-07-17 19:46 ` [PATCH v11 2/2] dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller Maxime Ripard
2014-07-17 19:46   ` Maxime Ripard
2014-07-24 12:13 ` [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller Maxime Ripard
2014-07-24 12:13   ` Maxime Ripard
2014-07-24 23:44   ` Andrew Morton
2014-07-24 23:44     ` Andrew Morton
2014-07-25  6:11     ` Vinod Koul
2014-07-25  6:11       ` Vinod Koul
2014-07-25  6:13       ` Vinod Koul
2014-07-25  6:13         ` Vinod Koul
2014-07-25  7:14         ` Andrew Morton
2014-07-25  7:14           ` Andrew Morton
2014-07-25 13:12 ` Vinod Koul [this message]
2014-07-25 13:12   ` Vinod Koul
2014-07-25 16:37   ` Maxime Ripard
2014-07-25 16:37     ` Maxime Ripard
2014-07-25 16:42     ` Vinod Koul
2014-07-25 16:42       ` Vinod Koul
2014-07-28 10:14       ` Maxime Ripard
2014-07-28 10:14         ` Maxime Ripard
2014-07-28 14:18         ` Vinod Koul
2014-07-28 14:18           ` Vinod Koul
2014-07-29 16:03           ` Maxime Ripard
2014-07-29 16:03             ` Maxime Ripard
2014-07-25 16:45     ` Russell King - ARM Linux
2014-07-25 16:45       ` Russell King - ARM Linux
2014-07-28  9:41       ` Maxime Ripard
2014-07-28  9:41         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725131217.GS8181@intel.com \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.