All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, thp: restructure thp avoidance of light synchronous migration
Date: Fri, 25 Jul 2014 16:38:59 +0100	[thread overview]
Message-ID: <20140725153859.GK10819@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1407241540190.22557@chino.kir.corp.google.com>

On Thu, Jul 24, 2014 at 03:41:06PM -0700, David Rientjes wrote:
> __GFP_NO_KSWAPD, once the way to determine if an allocation was for thp or not, 
> has gained more users.  Their use is not necessarily wrong, they are trying to 
> do a memory allocation that can easily fail without disturbing kswapd, so the 
> bit has gained additional usecases.
> 
> This restructures the check to determine whether MIGRATE_SYNC_LIGHT should be 
> used for memory compaction in the page allocator.  Rather than testing solely 
> for __GFP_NO_KSWAPD, test for all bits that must be set for thp allocations.
> 
> This also moves the check to be done only after the page allocator is aborted 
> for deferred or contended memory compaction since setting migration_mode for 
> this case is pointless.
> 
> Signed-off-by: David Rientjes <rientjes@google.com>

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, thp: restructure thp avoidance of light synchronous migration
Date: Fri, 25 Jul 2014 16:38:59 +0100	[thread overview]
Message-ID: <20140725153859.GK10819@suse.de> (raw)
In-Reply-To: <alpine.DEB.2.02.1407241540190.22557@chino.kir.corp.google.com>

On Thu, Jul 24, 2014 at 03:41:06PM -0700, David Rientjes wrote:
> __GFP_NO_KSWAPD, once the way to determine if an allocation was for thp or not, 
> has gained more users.  Their use is not necessarily wrong, they are trying to 
> do a memory allocation that can easily fail without disturbing kswapd, so the 
> bit has gained additional usecases.
> 
> This restructures the check to determine whether MIGRATE_SYNC_LIGHT should be 
> used for memory compaction in the page allocator.  Rather than testing solely 
> for __GFP_NO_KSWAPD, test for all bits that must be set for thp allocations.
> 
> This also moves the check to be done only after the page allocator is aborted 
> for deferred or contended memory compaction since setting migration_mode for 
> this case is pointless.
> 
> Signed-off-by: David Rientjes <rientjes@google.com>

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2014-07-25 15:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 22:41 [patch] mm, thp: restructure thp avoidance of light synchronous migration David Rientjes
2014-07-24 22:41 ` David Rientjes
2014-07-25 15:38 ` Mel Gorman [this message]
2014-07-25 15:38   ` Mel Gorman
2014-07-28  8:52 ` Vlastimil Babka
2014-07-28  8:52   ` Vlastimil Babka
2014-07-28 22:24   ` David Rientjes
2014-07-28 22:24     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725153859.GK10819@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.