From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o
Date: Sun, 27 Jul 2014 20:40:10 +0200 [thread overview]
Message-ID: <20140727184010.GA26029@ravnborg.org> (raw)
In-Reply-To: <CAKv+Gu9S8vVALGFR1qL+sFfnUuYR9pkkwy0t6NuJHrs9bVxdBw@mail.gmail.com>
>
> > Btw. the current solution is already faulty - even with the fix.
> > There are no support for make C=2 arch/.../crypto/
> >
>
> So can you elaborate on how it is faulty?
When you run "make C=2 arch/.../crypto/" then sparse shall be run
for all .c files also if they are already built.
But due to the re-implementation of some parts of the kbuild logic
in the makefile this does not happen with the -glue file.
A minor detail - but this may not be the only wreckage we see over time.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andreas Schwab <schwab@suse.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o
Date: Sun, 27 Jul 2014 20:40:10 +0200 [thread overview]
Message-ID: <20140727184010.GA26029@ravnborg.org> (raw)
In-Reply-To: <CAKv+Gu9S8vVALGFR1qL+sFfnUuYR9pkkwy0t6NuJHrs9bVxdBw@mail.gmail.com>
>
> > Btw. the current solution is already faulty - even with the fix.
> > There are no support for make C=2 arch/.../crypto/
> >
>
> So can you elaborate on how it is faulty?
When you run "make C=2 arch/.../crypto/" then sparse shall be run
for all .c files also if they are already built.
But due to the re-implementation of some parts of the kbuild logic
in the makefile this does not happen with the -glue file.
A minor detail - but this may not be the only wreckage we see over time.
Sam
next prev parent reply other threads:[~2014-07-27 18:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 13:14 [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o Andreas Schwab
2014-06-30 13:14 ` Andreas Schwab
2014-06-30 13:38 ` Ard Biesheuvel
2014-06-30 13:38 ` Ard Biesheuvel
2014-06-30 13:56 ` Andreas Schwab
2014-06-30 13:56 ` Andreas Schwab
2014-06-30 14:08 ` Ard Biesheuvel
2014-06-30 14:08 ` Ard Biesheuvel
2014-07-24 12:29 ` Andreas Schwab
2014-07-24 12:29 ` Andreas Schwab
2014-07-24 12:35 ` Ard Biesheuvel
2014-07-24 12:35 ` Ard Biesheuvel
2014-07-24 12:53 ` Ard Biesheuvel
2014-07-24 12:53 ` Ard Biesheuvel
2014-07-24 13:26 ` Andreas Schwab
2014-07-24 13:26 ` Andreas Schwab
2014-07-24 13:29 ` Ard Biesheuvel
2014-07-24 13:29 ` Ard Biesheuvel
2014-07-24 13:40 ` Andreas Schwab
2014-07-24 13:40 ` Andreas Schwab
2014-07-24 14:18 ` Ard Biesheuvel
2014-07-24 14:18 ` Ard Biesheuvel
2014-07-24 14:24 ` Ard Biesheuvel
2014-07-24 14:24 ` Ard Biesheuvel
2014-07-24 16:12 ` Sam Ravnborg
2014-07-24 16:12 ` Sam Ravnborg
2014-07-24 19:25 ` Ard Biesheuvel
2014-07-24 19:25 ` Ard Biesheuvel
2014-07-24 20:45 ` Sam Ravnborg
2014-07-24 20:45 ` Sam Ravnborg
2014-07-25 6:28 ` Ard Biesheuvel
2014-07-25 6:28 ` Ard Biesheuvel
2014-07-27 18:40 ` Sam Ravnborg [this message]
2014-07-27 18:40 ` Sam Ravnborg
2014-07-28 17:00 ` Ard Biesheuvel
2014-07-28 17:00 ` Ard Biesheuvel
2014-07-28 19:06 ` Sam Ravnborg
2014-07-28 19:06 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2014-07-24 16:03 Ard Biesheuvel
2014-07-24 16:47 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727184010.GA26029@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.