From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v3 1/2] pwm: lpss: properly split driver to parts
Date: Mon, 28 Jul 2014 18:34:11 +0300 [thread overview]
Message-ID: <20140728153411.GO1857@lahna.fi.intel.com> (raw)
In-Reply-To: <1406559792-30652-2-git-send-email-andriy.shevchenko@linux.intel.com>
On Mon, Jul 28, 2014 at 06:03:11PM +0300, Andy Shevchenko wrote:
> The driver consists core, PCI, and platform parts. It would better to split
> them into separate files.
>
> The platform driver is now called pwm-lpss-platform. Thus, prevously set
> CONFIG_PWM_LPSS=m is not enough to build it. But we are on the safe side since
> it seems no one from outside Intel is using it for now.
>
> While here, move to use macros module_pci_driver() and
> module_platform_driver().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Looks good to me now,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2014-07-28 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 15:03 [PATCH v3 0/2] pwm: lpss: split driver to core and probe drivers Andy Shevchenko
2014-07-28 15:03 ` [PATCH v3 1/2] pwm: lpss: properly split driver to parts Andy Shevchenko
2014-07-28 15:34 ` Mika Westerberg [this message]
2014-07-28 15:03 ` [PATCH v3 2/2] pwm: lpss: pci: move to use pcim_enable_device() Andy Shevchenko
2014-07-28 15:29 ` [PATCH v3 0/2] pwm: lpss: split driver to core and probe drivers Thierry Reding
2014-07-29 8:57 ` Andy Shevchenko
2014-07-29 10:10 ` Thierry Reding
2014-07-29 11:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728153411.GO1857@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.