From: Thierry Reding <thierry.reding@gmail.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: bhelgaas@google.com, swarren@wwwdotorg.org,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq
Date: Mon, 28 Jul 2014 17:35:50 +0200 [thread overview]
Message-ID: <20140728153548.GB10126@ulmo.nvidia.com> (raw)
In-Reply-To: <1406519142-3018-1-git-send-email-jszhang@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
On Mon, Jul 28, 2014 at 11:45:42AM +0800, Jisheng Zhang wrote:
> We should call tegra_msi_free() to free the msi bit if
> irq_create_mapping() fails. And we need to dispose the irq mapping
> during irq teardown.
"MSI" and "IRQ" please.
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index 083cf37..4ccc418 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1203,8 +1203,10 @@ static int tegra_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev,
> return hwirq;
>
> irq = irq_create_mapping(msi->domain, hwirq);
> - if (!irq)
> + if (!irq) {
> + tegra_msi_free(msi, hwirq);
> return -EINVAL;
> + }
>
> irq_set_msi_desc(irq, desc);
>
> @@ -1222,8 +1224,10 @@ static void tegra_msi_teardown_irq(struct msi_chip *chip, unsigned int irq)
> {
> struct tegra_msi *msi = to_tegra_msi(chip);
> struct irq_data *d = irq_get_irq_data(irq);
> + unsigned long hwirq = d->hwirq;
I don't think we need this temporary variable, d->hwirq isn't overly
long.
With both of the above address, this is:
Reviewed-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Cc: bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq
Date: Mon, 28 Jul 2014 17:35:50 +0200 [thread overview]
Message-ID: <20140728153548.GB10126@ulmo.nvidia.com> (raw)
In-Reply-To: <1406519142-3018-1-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
On Mon, Jul 28, 2014 at 11:45:42AM +0800, Jisheng Zhang wrote:
> We should call tegra_msi_free() to free the msi bit if
> irq_create_mapping() fails. And we need to dispose the irq mapping
> during irq teardown.
"MSI" and "IRQ" please.
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index 083cf37..4ccc418 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -1203,8 +1203,10 @@ static int tegra_msi_setup_irq(struct msi_chip *chip, struct pci_dev *pdev,
> return hwirq;
>
> irq = irq_create_mapping(msi->domain, hwirq);
> - if (!irq)
> + if (!irq) {
> + tegra_msi_free(msi, hwirq);
> return -EINVAL;
> + }
>
> irq_set_msi_desc(irq, desc);
>
> @@ -1222,8 +1224,10 @@ static void tegra_msi_teardown_irq(struct msi_chip *chip, unsigned int irq)
> {
> struct tegra_msi *msi = to_tegra_msi(chip);
> struct irq_data *d = irq_get_irq_data(irq);
> + unsigned long hwirq = d->hwirq;
I don't think we need this temporary variable, d->hwirq isn't overly
long.
With both of the above address, this is:
Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-28 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 3:45 [PATCH v2] PCI: tegra: add missing cleanup in error path and teardown_irq Jisheng Zhang
2014-07-28 3:45 ` Jisheng Zhang
2014-07-28 15:35 ` Thierry Reding [this message]
2014-07-28 15:35 ` Thierry Reding
2014-07-29 1:42 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140728153548.GB10126@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.