All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: David Miller <davem@davemloft.net>,
	Zoltan Kiss <zoltan.kiss@citrix.com>,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Tue, 29 Jul 2014 16:36:15 -0700	[thread overview]
Message-ID: <20140729233615.GA28154@kroah.com> (raw)
In-Reply-To: <1402070467.23860.1.camel@deadeye.wl.decadent.org.uk>

On Fri, Jun 06, 2014 at 05:01:07PM +0100, Ben Hutchings wrote:
> [Trimmed cc list; added Greg and stable]
> 
> On Tue, 2014-04-22 at 20:18 +0100, Ben Hutchings wrote:
> > From: Zoltan Kiss <zoltan.kiss@citrix.com>
> > 
> > commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream.
> > 
> > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> > orphan them. Also, it doesn't handle errors, so this patch takes care of that
> > as well, and modify the callers accordingly. skb_tx_error() is also added to
> > the callers so they will signal the failed delivery towards the creator of the
> > skb.
> > 
> > Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > [bwh: Backported to 3.13: skb_zerocopy() is new in 3.14, but was moved from a
> >  static function in nfnetlink_queue.  We need to patch that and its caller, but
> >  not openvswitch.]
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> 
> I noticed this is still not applied or queued for the 3.10.y branch, but
> it does seem to be needed.

Thanks, I've queued this up for 3.10-stable.

greg k-h

  reply	other threads:[~2014-07-29 23:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 22:37 [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Zoltan Kiss
2014-03-26 22:37 ` Zoltan Kiss
2014-03-26 22:37 ` Zoltan Kiss
2014-03-27 19:29 ` David Miller
     [not found] ` <1395873465-22282-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-27 19:29   ` David Miller
2014-03-27 19:29     ` David Miller
     [not found]     ` <20140327.152956.1528740039185894234.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-04-21 11:26       ` Luis Henriques
2014-04-21 11:26         ` Luis Henriques
2014-04-22 15:38         ` Ben Hutchings
2014-04-22 15:38         ` Ben Hutchings
2014-04-22 15:38           ` Ben Hutchings
2014-04-22 18:02           ` Zoltan Kiss
     [not found]           ` <1398181118.3624.203.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-04-22 18:02             ` Zoltan Kiss
2014-04-22 18:02               ` Zoltan Kiss
     [not found]               ` <5356AEBF.5010505-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-04-22 19:18                 ` [PATCH 3.13] " Ben Hutchings
2014-04-22 19:18                   ` Ben Hutchings
2014-04-23  8:57                   ` Luis Henriques
2014-04-23 12:34                   ` Zoltan Kiss
     [not found]                   ` <1398194284.7767.101.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-04-23  8:57                     ` Luis Henriques
2014-04-23  8:57                       ` Luis Henriques
2014-04-23 12:34                     ` Zoltan Kiss
2014-04-23 12:34                       ` Zoltan Kiss
2014-04-23 13:31                   ` Josh Boyer
2014-04-23 13:31                   ` Josh Boyer
2014-06-06 16:01                   ` Ben Hutchings
2014-07-29 23:36                     ` Greg Kroah-Hartman [this message]
2014-04-22 19:18               ` Ben Hutchings
2014-04-21 11:26     ` [PATCH v5] " Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140729233615.GA28154@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben@decadent.org.uk \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.