From: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
To: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
Luis Henriques
<luis.henriques-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mszeredi-AlSwsSmVLrQ@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
JBeulich-IBi9RG/b67k@public.gmane.org,
therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org,
xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org,
pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org,
jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org,
Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Tue, 22 Apr 2014 19:02:39 +0100 [thread overview]
Message-ID: <5356AEBF.5010505@citrix.com> (raw)
In-Reply-To: <1398181118.3624.203.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
On 22/04/14 16:38, Ben Hutchings wrote:
> On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote:
>> Hi David,
>>
>> On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote:
>>> From: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
>>> Date: Wed, 26 Mar 2014 22:37:45 +0000
>>>
>>>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>>>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>>>> as well, and modify the callers accordingly. skb_tx_error() is also added to
>>>> the callers so they will signal the failed delivery towards the creator of the
>>>> skb.
>>>>
>>>> Signed-off-by: Zoltan Kiss <zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
>>>
>>> Fingers crossed :-) Applied, thanks Zoltan.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> Could you please queue this for stable as well? It has CVE-2014-2568
>> assigned to it and I believe it is applicable to some of the trees.
>
> It was applied to 3.13, but needs backporting to earlier versions. I
> posted my attempt in
> <1397429860.10849.86.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org> but it needs
> testing/reviewing.
This one is a different issue, although it is very similar.
Zoli
WARNING: multiple messages have this Message-ID (diff)
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Ben Hutchings <ben@decadent.org.uk>,
Luis Henriques <luis.henriques@canonical.com>
Cc: David Miller <davem@davemloft.net>, <jesse@nicira.com>,
<pshelar@nicira.com>, <tgraf@redhat.com>, <dev@openvswitch.org>,
<pablo@netfilter.org>, <kadlec@blackhole.kfki.hu>,
<edumazet@google.com>, <dborkman@redhat.com>,
<therbert@google.com>, <jasowang@redhat.com>, <fw@strlen.de>,
<joe@perches.com>, <horms@verge.net.au>, <jiri@resnulli.us>,
<mst@redhat.com>, <Paul.Durrant@citrix.com>, <JBeulich@suse.com>,
<herbert@gondor.apana.org.au>, <mszeredi@suse.cz>,
<netfilter-devel@vger.kernel.org>, <netfilter@vger.kernel.org>,
<xen-devel@lists.xenproject.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
Date: Tue, 22 Apr 2014 19:02:39 +0100 [thread overview]
Message-ID: <5356AEBF.5010505@citrix.com> (raw)
In-Reply-To: <1398181118.3624.203.camel@deadeye.wl.decadent.org.uk>
On 22/04/14 16:38, Ben Hutchings wrote:
> On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote:
>> Hi David,
>>
>> On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote:
>>> From: Zoltan Kiss <zoltan.kiss@citrix.com>
>>> Date: Wed, 26 Mar 2014 22:37:45 +0000
>>>
>>>> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
>>>> orphan them. Also, it doesn't handle errors, so this patch takes care of that
>>>> as well, and modify the callers accordingly. skb_tx_error() is also added to
>>>> the callers so they will signal the failed delivery towards the creator of the
>>>> skb.
>>>>
>>>> Signed-off-by: Zoltan Kiss <zoltan.kiss@citrix.com>
>>>
>>> Fingers crossed :-) Applied, thanks Zoltan.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> Could you please queue this for stable as well? It has CVE-2014-2568
>> assigned to it and I believe it is applicable to some of the trees.
>
> It was applied to 3.13, but needs backporting to earlier versions. I
> posted my attempt in
> <1397429860.10849.86.camel@deadeye.wl.decadent.org.uk> but it needs
> testing/reviewing.
This one is a different issue, although it is very similar.
Zoli
next prev parent reply other threads:[~2014-04-22 18:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 22:37 [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors Zoltan Kiss
2014-03-26 22:37 ` Zoltan Kiss
2014-03-26 22:37 ` Zoltan Kiss
2014-03-27 19:29 ` David Miller
[not found] ` <1395873465-22282-1-git-send-email-zoltan.kiss-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-03-27 19:29 ` David Miller
2014-03-27 19:29 ` David Miller
[not found] ` <20140327.152956.1528740039185894234.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-04-21 11:26 ` Luis Henriques
2014-04-21 11:26 ` Luis Henriques
2014-04-22 15:38 ` Ben Hutchings
2014-04-22 15:38 ` Ben Hutchings
2014-04-22 18:02 ` Zoltan Kiss
[not found] ` <1398181118.3624.203.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-04-22 18:02 ` Zoltan Kiss [this message]
2014-04-22 18:02 ` Zoltan Kiss
[not found] ` <5356AEBF.5010505-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org>
2014-04-22 19:18 ` [PATCH 3.13] " Ben Hutchings
2014-04-22 19:18 ` Ben Hutchings
2014-04-23 8:57 ` Luis Henriques
2014-04-23 12:34 ` Zoltan Kiss
[not found] ` <1398194284.7767.101.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2014-04-23 8:57 ` Luis Henriques
2014-04-23 8:57 ` Luis Henriques
2014-04-23 12:34 ` Zoltan Kiss
2014-04-23 12:34 ` Zoltan Kiss
2014-04-23 13:31 ` Josh Boyer
2014-04-23 13:31 ` Josh Boyer
2014-06-06 16:01 ` Ben Hutchings
2014-07-29 23:36 ` Greg Kroah-Hartman
2014-04-22 19:18 ` Ben Hutchings
2014-04-22 15:38 ` [PATCH v5] " Ben Hutchings
2014-04-21 11:26 ` Luis Henriques
-- strict thread matches above, loose matches on Subject: below --
2014-03-26 22:37 Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356AEBF.5010505@citrix.com \
--to=zoltan.kiss-sxgqhf6nn4dqt0dzr+alfa@public.gmane.org \
--cc=JBeulich-IBi9RG/b67k@public.gmane.org \
--cc=Paul.Durrant-Sxgqhf6Nn4DQT0dZR+AlfA@public.gmane.org \
--cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dborkman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=jasowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=kadlec-K40Dz/62t/MgiyqX0sVFJYdd74u8MsAO@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luis.henriques-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mszeredi-AlSwsSmVLrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org \
--cc=therbert-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.