From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, oom: remove unnecessary exit_state check
Date: Wed, 30 Jul 2014 17:06:15 +0200 [thread overview]
Message-ID: <20140730150615.GA20659@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407291638310.858@chino.kir.corp.google.com>
On 07/29, David Rientjes wrote:
>
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -455,6 +455,7 @@ static void exit_mm(struct task_struct * tsk)
> task_unlock(tsk);
> mm_update_next_owner(mm);
> mmput(mm);
> + clear_thread_flag(TIF_MEMDIE);
> }
>
> /*
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -258,8 +258,6 @@ enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
> unsigned long totalpages, const nodemask_t *nodemask,
> bool force_kill)
> {
> - if (task->exit_state)
> - return OOM_SCAN_CONTINUE;
IIRC, this check was a workaround, to ensure that a oom-killed zombie
can't block oom-killer.
I think this patch can equally work.
Oleg.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, oom: remove unnecessary exit_state check
Date: Wed, 30 Jul 2014 17:06:15 +0200 [thread overview]
Message-ID: <20140730150615.GA20659@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407291638310.858@chino.kir.corp.google.com>
On 07/29, David Rientjes wrote:
>
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -455,6 +455,7 @@ static void exit_mm(struct task_struct * tsk)
> task_unlock(tsk);
> mm_update_next_owner(mm);
> mmput(mm);
> + clear_thread_flag(TIF_MEMDIE);
> }
>
> /*
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -258,8 +258,6 @@ enum oom_scan_t oom_scan_process_thread(struct task_struct *task,
> unsigned long totalpages, const nodemask_t *nodemask,
> bool force_kill)
> {
> - if (task->exit_state)
> - return OOM_SCAN_CONTINUE;
IIRC, this check was a workaround, to ensure that a oom-killed zombie
can't block oom-killer.
I think this patch can equally work.
Oleg.
next prev parent reply other threads:[~2014-07-30 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 23:39 [patch] mm, oom: remove unnecessary exit_state check David Rientjes
2014-07-29 23:39 ` David Rientjes
2014-07-30 15:06 ` Oleg Nesterov [this message]
2014-07-30 15:06 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730150615.GA20659@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.