All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers
@ 2014-07-31  9:33 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-07-31  9:33 UTC (permalink / raw)
  To: nicoleotsuka; +Cc: alsa-devel

Hello Nicolin Chen,

This is a semi-automatic email about new static checker warnings.

The patch 3117bb3109dc: "ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and 
platform drivers" from Jul 29, 2014, leads to the following Smatch 
complaint:

sound/soc/fsl/fsl_asrc_dma.c:304 fsl_asrc_dma_shutdown()
	 warn: variable dereferenced before check 'pair' (see line 302)

sound/soc/fsl/fsl_asrc_dma.c
   301		struct fsl_asrc_pair *pair = runtime->private_data;
   302		struct fsl_asrc *asrc_priv = pair->asrc_priv;
                                             ^^^^^^^^^^^^^^^
Dereference.

   303	
   304		if (pair && asrc_priv->pair[pair->index] == pair)
                    ^^^^

Check.

   305			asrc_priv->pair[pair->index] = NULL;
   306	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-07-31  9:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-31  9:33 ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.