* [patch] ASoC: pxa: pxa-ssp: small leak in probe()
@ 2014-07-31 12:57 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-07-31 12:57 UTC (permalink / raw)
To: Eric Miao
Cc: Russell King, Haojian Zhuang, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Grant Likely, Rob Herring,
linux-arm-kernel, alsa-devel, kernel-janitors
There is a small memory leak if probe() fails.
Fixes: 2023c90c3a2c ('ASoC: pxa: pxa-ssp: add DT bindings')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 199a8b3..0109f6c2 100644
--- a/sound/soc/pxa/pxa-ssp.c
+++ b/sound/soc/pxa/pxa-ssp.c
@@ -723,7 +723,8 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
ssp_handle = of_parse_phandle(dev->of_node, "port", 0);
if (!ssp_handle) {
dev_err(dev, "unable to get 'port' phandle\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err_priv;
}
priv->ssp = pxa_ssp_request_of(ssp_handle, "SoC audio");
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] ASoC: pxa: pxa-ssp: small leak in probe()
@ 2014-07-31 12:57 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-07-31 12:57 UTC (permalink / raw)
To: linux-arm-kernel
There is a small memory leak if probe() fails.
Fixes: 2023c90c3a2c ('ASoC: pxa: pxa-ssp: add DT bindings')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 199a8b3..0109f6c2 100644
--- a/sound/soc/pxa/pxa-ssp.c
+++ b/sound/soc/pxa/pxa-ssp.c
@@ -723,7 +723,8 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
ssp_handle = of_parse_phandle(dev->of_node, "port", 0);
if (!ssp_handle) {
dev_err(dev, "unable to get 'port' phandle\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err_priv;
}
priv->ssp = pxa_ssp_request_of(ssp_handle, "SoC audio");
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] ASoC: pxa: pxa-ssp: small leak in probe()
@ 2014-07-31 12:57 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2014-07-31 12:57 UTC (permalink / raw)
To: Eric Miao
Cc: Russell King, Haojian Zhuang, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Grant Likely, Rob Herring,
linux-arm-kernel, alsa-devel, kernel-janitors
There is a small memory leak if probe() fails.
Fixes: 2023c90c3a2c ('ASoC: pxa: pxa-ssp: add DT bindings')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 199a8b3..0109f6c2 100644
--- a/sound/soc/pxa/pxa-ssp.c
+++ b/sound/soc/pxa/pxa-ssp.c
@@ -723,7 +723,8 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
ssp_handle = of_parse_phandle(dev->of_node, "port", 0);
if (!ssp_handle) {
dev_err(dev, "unable to get 'port' phandle\n");
- return -ENODEV;
+ ret = -ENODEV;
+ goto err_priv;
}
priv->ssp = pxa_ssp_request_of(ssp_handle, "SoC audio");
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] ASoC: pxa: pxa-ssp: small leak in probe()
2014-07-31 12:57 ` Dan Carpenter
(?)
@ 2014-07-31 19:27 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-31 19:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Eric Miao, Russell King, Haojian Zhuang, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Grant Likely, Rob Herring,
linux-arm-kernel, alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
On Thu, Jul 31, 2014 at 03:57:51PM +0300, Dan Carpenter wrote:
> There is a small memory leak if probe() fails.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] ASoC: pxa: pxa-ssp: small leak in probe()
@ 2014-07-31 19:27 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-31 19:27 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 31, 2014 at 03:57:51PM +0300, Dan Carpenter wrote:
> There is a small memory leak if probe() fails.
Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140731/afd2d0dc/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ASoC: pxa: pxa-ssp: small leak in probe()
@ 2014-07-31 19:27 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-31 19:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Eric Miao, Russell King, Haojian Zhuang, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Grant Likely, Rob Herring,
linux-arm-kernel, alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
On Thu, Jul 31, 2014 at 03:57:51PM +0300, Dan Carpenter wrote:
> There is a small memory leak if probe() fails.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-31 19:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-31 12:57 [patch] ASoC: pxa: pxa-ssp: small leak in probe() Dan Carpenter
2014-07-31 12:57 ` Dan Carpenter
2014-07-31 12:57 ` Dan Carpenter
2014-07-31 19:27 ` Mark Brown
2014-07-31 19:27 ` Mark Brown
2014-07-31 19:27 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.