From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller
Date: Thu, 31 Jul 2014 15:17:02 +0200 [thread overview]
Message-ID: <20140731131702.GC4375@pd.tnic> (raw)
In-Reply-To: <808655a9-77eb-4e3a-9781-2b059ad9517b@BN1AFFO11FD020.protection.gbl>
On Thu, Jul 31, 2014 at 02:13:48PM +0200, Michal Simek wrote:
> Mixing two drivers in the one file is not a good idea because with
> more memory controllers it is just a mess and you are not able to
> cover all cases.
Why is it a mess?
> If this is just about providing uniq number we can easily extend
> binding and provide that uniq value. That's remind me solution with
> edac_mc_get_id() can caused that you won't have exact number all the
> time - depends on driver loading (deferred probing too).
-ENOPARSE for this sentence.
> One option via DT can be via aliases where you can easily specify
> order. But all of these issues can be solved in follow-up patch.
Whatever you do, it should be designed cleanly and not introduce some
homegrown solution.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
"dougthompson@xmission.com" <dougthompson@xmission.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Punnaiah Choudary <kpc528@gmail.com>,
Anirudha Sarangi <anirudh@xilinx.com>,
Srikanth Vemula <svemula@xilinx.com>
Subject: Re: [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller
Date: Thu, 31 Jul 2014 15:17:02 +0200 [thread overview]
Message-ID: <20140731131702.GC4375@pd.tnic> (raw)
In-Reply-To: <808655a9-77eb-4e3a-9781-2b059ad9517b@BN1AFFO11FD020.protection.gbl>
On Thu, Jul 31, 2014 at 02:13:48PM +0200, Michal Simek wrote:
> Mixing two drivers in the one file is not a good idea because with
> more memory controllers it is just a mess and you are not able to
> cover all cases.
Why is it a mess?
> If this is just about providing uniq number we can easily extend
> binding and provide that uniq value. That's remind me solution with
> edac_mc_get_id() can caused that you won't have exact number all the
> time - depends on driver loading (deferred probing too).
-ENOPARSE for this sentence.
> One option via DT can be via aliases where you can easily specify
> order. But all of these issues can be solved in follow-up patch.
Whatever you do, it should be designed cleanly and not introduce some
homegrown solution.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-07-31 13:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 15:41 [RFC PATCH v3] edac: synps: Added EDAC support for zynq ddr ecc controller Punnaiah Choudary Kalluri
2014-07-30 15:41 ` Punnaiah Choudary Kalluri
2014-07-31 11:33 ` Borislav Petkov
2014-07-31 11:33 ` Borislav Petkov
2014-07-31 11:33 ` Borislav Petkov
2014-07-31 12:13 ` Michal Simek
2014-07-31 12:13 ` Michal Simek
2014-07-31 13:17 ` Borislav Petkov [this message]
2014-07-31 13:17 ` Borislav Petkov
2014-07-31 13:36 ` Michal Simek
2014-07-31 13:36 ` Michal Simek
2014-07-31 13:36 ` Michal Simek
2014-07-31 13:56 ` Borislav Petkov
2014-07-31 13:56 ` Borislav Petkov
2014-07-31 14:19 ` Punnaiah Choudary Kalluri
2014-07-31 14:19 ` Punnaiah Choudary Kalluri
2014-07-31 14:19 ` Punnaiah Choudary Kalluri
[not found] <03CA77BA8AF6F1469AEDFBDA1322A7B74821CC98@XAP-PVEXMBX01.xlnx.xilinx.com>
2014-07-31 9:33 ` Michal Simek
2014-07-31 9:33 ` Michal Simek
-- strict thread matches above, loose matches on Subject: below --
2014-07-26 18:40 Punnaiah Choudary Kalluri
2014-07-26 18:40 ` Punnaiah Choudary Kalluri
2014-07-26 18:40 ` Punnaiah Choudary Kalluri
2014-07-28 11:34 ` Borislav Petkov
2014-07-28 11:34 ` Borislav Petkov
2014-07-28 17:23 ` punnaiah choudary kalluri
2014-07-28 17:23 ` punnaiah choudary kalluri
2014-07-28 18:01 ` Borislav Petkov
2014-07-28 18:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731131702.GC4375@pd.tnic \
--to=bp@alien8.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.