Re: [PATCH v2 tip/core/rcu 04/10] rcu: Export RCU-tasks APIs to GPL modules

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Thu, Jul 31, 2014 at 09:56:20AM -0700, josh@joshtriplett.org wrote:
> On Wed, Jul 30, 2014 at 05:39:36PM -0700, Paul E. McKenney wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> > 
> > This commit exports the RCU-tasks APIs, call_rcu_tasks(),
> > synchronize_rcu_tasks(), and rcu_barrier_tasks(), to GPL-licensed
> > kernel modules.
> > 
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> 
> Should this remain a separate patch, or go into the patch that creates
> these APIs?

Excellent question.  Keeping them separate for now, but...

							Thanx, Paul

> >  kernel/rcu/update.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index c8d304dc6d8a..1bfc07ed854e 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -429,6 +429,7 @@ void synchronize_rcu_tasks(void)
> >  	/* Wait for the grace period. */
> >  	wait_rcu_gp(call_rcu_tasks);
> >  }
> > +EXPORT_SYMBOL_GPL(synchronize_rcu_tasks);
> >  
> >  /**
> >   * rcu_barrier_tasks - Wait for in-flight call_rcu_tasks() callbacks.
> > @@ -441,6 +442,7 @@ void rcu_barrier_tasks(void)
> >  	/* There is only one callback queue, so this is easy.  ;-) */
> >  	synchronize_rcu_tasks();
> >  }
> > +EXPORT_SYMBOL_GPL(rcu_barrier_tasks);
> >  
> >  /* RCU-tasks kthread that detects grace periods and invokes callbacks. */
> >  static int __noreturn rcu_tasks_kthread(void *arg)
> > -- 
> > 1.8.1.5
> > 
>