From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents
Date: Fri, 1 Aug 2014 09:02:12 +1000 [thread overview]
Message-ID: <20140731230212.GT26465@dastard> (raw)
In-Reply-To: <20140731171602.GF22173@infradead.org>
On Thu, Jul 31, 2014 at 10:16:02AM -0700, Christoph Hellwig wrote:
> > int
> > +xfs_swap_extent_flush(
> > + struct xfs_inode *ip)
> > +{
> > + int error;
>
> nipick: shouldn't the arguments and local variables align to the same
> level?
*nod*
> Also a local struct inode variable instead of using VFS_I(ip) 4 times
> would be nice.
Will fix.
> Otherwise looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks.
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-07-31 23:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 6:12 [PATCH 0/2] xfs: extent swap fixes Dave Chinner
2014-07-31 6:12 ` [PATCH 1/2] xfs: fix swapext ilock deadlock Dave Chinner
2014-07-31 17:15 ` Christoph Hellwig
2014-07-31 6:12 ` [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents Dave Chinner
2014-07-31 17:16 ` Christoph Hellwig
2014-07-31 23:02 ` Dave Chinner [this message]
2014-08-01 12:44 ` Brian Foster
2014-08-02 3:19 ` Dave Chinner
2014-08-02 11:24 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2014-06-06 8:22 [PATCH 0/2] xfs: fix a couple of swap extent issues Dave Chinner
2014-06-06 8:22 ` [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731230212.GT26465@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.