From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents
Date: Sat, 2 Aug 2014 13:19:31 +1000 [thread overview]
Message-ID: <20140802031931.GS20518@dastard> (raw)
In-Reply-To: <20140801124401.GA3582@laptop.bfoster>
On Fri, Aug 01, 2014 at 08:44:02AM -0400, Brian Foster wrote:
> On Thu, Jul 31, 2014 at 04:12:08PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > We need to treat both inodes identically from a page cache point of
> > view when prepareing them for extent swapping. We don't do this
> > right now - we assume that one of the inodes empty, because that's
> > what xfs_fsr currently does. Remove this assumption from the code.
> >
> > While factoring out the flushing and related checks, move the
> > transactions reservation to immeidately after the flushes so that we
> > don't need to pick up and then drop the ilock to do the transaction
> > reservation. There are no issues with aborting the transaction it if
> > the checks fail before we join the inodes to the transaction and
> > dirty them, so this is a safe change to make.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
>
> Both of these looked fine to me, but I couldn't apply this one to
> for-next or master...
It's actually in my working branch, which means it's based on
3.16-rc5 + random-outside-xfs-patches + for-next + verifier fixes +
sb discombobulation and then this patch set. I didn't check that it
applied directly against for-next - do you want me to rebase and
resend it?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-08-02 3:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 6:12 [PATCH 0/2] xfs: extent swap fixes Dave Chinner
2014-07-31 6:12 ` [PATCH 1/2] xfs: fix swapext ilock deadlock Dave Chinner
2014-07-31 17:15 ` Christoph Hellwig
2014-07-31 6:12 ` [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents Dave Chinner
2014-07-31 17:16 ` Christoph Hellwig
2014-07-31 23:02 ` Dave Chinner
2014-08-01 12:44 ` Brian Foster
2014-08-02 3:19 ` Dave Chinner [this message]
2014-08-02 11:24 ` Brian Foster
-- strict thread matches above, loose matches on Subject: below --
2014-06-06 8:22 [PATCH 0/2] xfs: fix a couple of swap extent issues Dave Chinner
2014-06-06 8:22 ` [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140802031931.GS20518@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.