All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Ruder <andrew.ruder@elecsyscorp.com>,
	Nikita Kiryanov <nikita@compulab.co.il>,
	Igor Grinberg <grinberg@compulab.co.il>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Jingoo Han <jg1.han@samsung.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Michael Abbott <michael.abbott@diamond.ac.uk>,
	Barry Song <Baohua.Song@csr.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] dm9000: NULL dereferences on error in probe()
Date: Fri, 01 Aug 2014 08:23:57 +0000	[thread overview]
Message-ID: <20140801082357.GC28869@mwanda> (raw)

The dm9000_release_board() function is called with NULL ->data_req and
->addr_req pointers if dm9000_probe() fails.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Old bug, but not serious.

diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
index 13723c9..23084fb 100644
--- a/drivers/net/ethernet/davicom/dm9000.c
+++ b/drivers/net/ethernet/davicom/dm9000.c
@@ -817,10 +817,12 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
 
 	/* release the resources */
 
-	release_resource(db->data_req);
+	if (db->data_req)
+		release_resource(db->data_req);
 	kfree(db->data_req);
 
-	release_resource(db->addr_req);
+	if (db->addr_req)
+		release_resource(db->addr_req);
 	kfree(db->addr_req);
 }
 

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Ruder <andrew.ruder@elecsyscorp.com>,
	Nikita Kiryanov <nikita@compulab.co.il>,
	Igor Grinberg <grinberg@compulab.co.il>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Jingoo Han <jg1.han@samsung.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Michael Abbott <michael.abbott@diamond.ac.uk>,
	Barry Song <Baohua.Song@csr.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] dm9000: NULL dereferences on error in probe()
Date: Fri, 1 Aug 2014 11:23:57 +0300	[thread overview]
Message-ID: <20140801082357.GC28869@mwanda> (raw)

The dm9000_release_board() function is called with NULL ->data_req and
->addr_req pointers if dm9000_probe() fails.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Old bug, but not serious.

diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
index 13723c9..23084fb 100644
--- a/drivers/net/ethernet/davicom/dm9000.c
+++ b/drivers/net/ethernet/davicom/dm9000.c
@@ -817,10 +817,12 @@ dm9000_release_board(struct platform_device *pdev, struct board_info *db)
 
 	/* release the resources */
 
-	release_resource(db->data_req);
+	if (db->data_req)
+		release_resource(db->data_req);
 	kfree(db->data_req);
 
-	release_resource(db->addr_req);
+	if (db->addr_req)
+		release_resource(db->addr_req);
 	kfree(db->addr_req);
 }
 

             reply	other threads:[~2014-08-01  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01  8:23 Dan Carpenter [this message]
2014-08-01  8:23 ` [patch] dm9000: NULL dereferences on error in probe() Dan Carpenter
2014-08-02 22:28 ` David Miller
2014-08-02 22:28   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801082357.GC28869@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Baohua.Song@csr.com \
    --cc=andrew.ruder@elecsyscorp.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=grant.likely@linaro.org \
    --cc=grinberg@compulab.co.il \
    --cc=jg1.han@samsung.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=michael.abbott@diamond.ac.uk \
    --cc=netdev@vger.kernel.org \
    --cc=nikita@compulab.co.il \
    --cc=paul.gortmaker@windriver.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.