From: Theodore Ts'o <tytso@mit.edu>
To: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Cc: linux-ext4@vger.kernel.org, adilger@dilger.ca, lczerner@redhat.com
Subject: Re: [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex
Date: Fri, 1 Aug 2014 08:40:37 -0400 [thread overview]
Message-ID: <20140801124037.GB15110@thunk.org> (raw)
In-Reply-To: <53DAE9CD.5090308@cn.fujitsu.com>
On Fri, Aug 01, 2014 at 09:13:49AM +0800, Xiaoguang Wang wrote:
> > I'm not sure why, and right now I don't have time to investigate. If
> > someone who has time and experience wading into fs/ext4/mballoc.c, it
> > would be great if someone could take a closer look.
>
> I'll investigate it and have full tests, thanks!
Thanks!
The patch *looked* correct, and it was pretty obvious, so I don't
entirely blame you for not running tests --- but it's why I tend to
run smoke tests regularly when merging in patches, and I do encourage
folks to run the smoke test for any patch, no matter how simple. Yes,
it takes 30 minutes, but it's worth it.
I suspect there may be some underlying bug which your patch unmasked,
so it would be good for us to understand why it caused the failure.
- Ted
next prev parent reply other threads:[~2014-08-01 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 9:47 [PATCH] ext4: save goal group and offset in struct ext4_allocation_context.ac_g_ex Xiaoguang Wang
2014-07-29 13:58 ` Theodore Ts'o
2014-07-31 15:32 ` Theodore Ts'o
2014-08-01 1:13 ` Xiaoguang Wang
2014-08-01 12:40 ` Theodore Ts'o [this message]
2014-08-04 7:00 ` Xiaoguang Wang
2014-08-04 10:39 ` [PATCH v2] " Xiaoguang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801124037.GB15110@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.