From: Johannes Weiner <hannes@cmpxchg.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist
Date: Fri, 1 Aug 2014 09:34:44 -0400 [thread overview]
Message-ID: <20140801133444.GH9952@cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1408010159500.4061@chino.kir.corp.google.com>
On Fri, Aug 01, 2014 at 02:10:37AM -0700, David Rientjes wrote:
> On Thu, 31 Jul 2014, Johannes Weiner wrote:
>
> > out_of_memory() wants the zonelist that was used during allocation,
> > not just the random first node's zonelist that's simply picked to
> > serialize page fault OOM kills system-wide.
> >
> > This would even change how panic_on_oom behaves for page fault OOMs
> > (in a completely unpredictable way) if we get CONSTRAINED_CPUSET.
> >
> > This change makes no sense to me.
> >
>
> Allocations during fault will be constrained by the cpuset's mems, if we
> are oom then why would we panic when panic_on_oom == 1?
Can you please address the concerns I raised?
And please describe user-visible changes in the changelog.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist
Date: Fri, 1 Aug 2014 09:34:44 -0400 [thread overview]
Message-ID: <20140801133444.GH9952@cmpxchg.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1408010159500.4061@chino.kir.corp.google.com>
On Fri, Aug 01, 2014 at 02:10:37AM -0700, David Rientjes wrote:
> On Thu, 31 Jul 2014, Johannes Weiner wrote:
>
> > out_of_memory() wants the zonelist that was used during allocation,
> > not just the random first node's zonelist that's simply picked to
> > serialize page fault OOM kills system-wide.
> >
> > This would even change how panic_on_oom behaves for page fault OOMs
> > (in a completely unpredictable way) if we get CONSTRAINED_CPUSET.
> >
> > This change makes no sense to me.
> >
>
> Allocations during fault will be constrained by the cpuset's mems, if we
> are oom then why would we panic when panic_on_oom == 1?
Can you please address the concerns I raised?
And please describe user-visible changes in the changelog.
next prev parent reply other threads:[~2014-08-01 13:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 1:16 [patch 1/3] mm, oom: ensure memoryless node zonelist always includes zones David Rientjes
2014-07-24 1:16 ` David Rientjes
2014-07-24 1:16 ` [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist David Rientjes
2014-07-24 1:16 ` David Rientjes
2014-07-31 15:26 ` Johannes Weiner
2014-07-31 15:26 ` Johannes Weiner
2014-08-01 9:10 ` David Rientjes
2014-08-01 9:10 ` David Rientjes
2014-08-01 13:34 ` Johannes Weiner [this message]
2014-08-01 13:34 ` Johannes Weiner
2014-08-01 21:42 ` David Rientjes
2014-08-01 21:42 ` David Rientjes
2014-08-02 18:13 ` Johannes Weiner
2014-08-02 18:13 ` Johannes Weiner
2014-08-05 0:18 ` David Rientjes
2014-08-05 0:18 ` David Rientjes
2014-07-24 1:16 ` [patch 3/3] mm, oom: rename zonelist locking functions David Rientjes
2014-07-24 1:16 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801133444.GH9952@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.