Re: [RFC PATCH 05/17] COLO save: integrate COLO checkpointed save into qemu migration

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Yang Hongyang (yanghy@cn.fujitsu.com) wrote:
>   Integrate COLO checkpointed save flow into qemu migration.
>   Add a migrate state: MIG_STATE_COLO, enter this migrate state
> after the first live migration successfully finished.
>   Create a colo thread to do the checkpointed save.

In postcopy I added a 'migration_already_active' function
to merge all the different places that check for ACTIVE/SETUP etc.
( http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg00850.html )

> +    /*TODO: COLO checkpointed save loop*/
> +
> +    if (s->state != MIG_STATE_ERROR) {
> +        migrate_set_state(s, MIG_STATE_COLO, MIG_STATE_COMPLETED);
> +    }

I thought migrate_set_state only changed the state if the old state
matched the 1st value - i.e. I think it'll only change to COMPLETED
if the state is COLO; so I don't think you need the if.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK