* Re: [PATCH] staging: rtl8188eu: Fix static symbol sparse warning
2014-08-05 18:49 [PATCH] staging: rtl8188eu: Fix static symbol sparse warning Miguel Oliveira
@ 2014-08-05 16:54 ` Fabio Estevam
2014-08-05 16:56 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2014-08-05 16:54 UTC (permalink / raw)
To: Miguel Oliveira
Cc: Greg Kroah-Hartman, devel, oat.elena, linux-kernel, paulmck,
Larry Finger
On Tue, Aug 5, 2014 at 3:49 PM, Miguel Oliveira <cmroliv@gmail.com> wrote:
> From: Miguel <cmroliv@gmail.com>
Please use your full name in the From field.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Fix static symbol sparse warning
2014-08-05 18:49 [PATCH] staging: rtl8188eu: Fix static symbol sparse warning Miguel Oliveira
2014-08-05 16:54 ` Fabio Estevam
@ 2014-08-05 16:56 ` Dan Carpenter
2014-08-05 17:01 ` Miguel Oliveira
1 sibling, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-08-05 16:56 UTC (permalink / raw)
To: Miguel Oliveira
Cc: gregkh, devel, oat.elena, linux-kernel, paulmck, Larry.Finger
On Tue, Aug 05, 2014 at 07:49:54PM +0100, Miguel Oliveira wrote:
> From: Miguel <cmroliv@gmail.com>
Leave this line out, git should get this from your email unless you are
sending on someone else's behalf. Also this name is wrong and your
email header has the correct full name.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: rtl8188eu: Fix static symbol sparse warning
2014-08-05 16:56 ` Dan Carpenter
@ 2014-08-05 17:01 ` Miguel Oliveira
0 siblings, 0 replies; 4+ messages in thread
From: Miguel Oliveira @ 2014-08-05 17:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg KH, devel, oat.elena, linux-kernel, paulmck, Larry.Finger
It was a git miss configuration in a new host, that was fixed.
Sorry for the inconvenient.
Regards,
Miguel Oliveira
2014-08-05 18:56 GMT+02:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Tue, Aug 05, 2014 at 07:49:54PM +0100, Miguel Oliveira wrote:
>> From: Miguel <cmroliv@gmail.com>
>
> Leave this line out, git should get this from your email unless you are
> sending on someone else's behalf. Also this name is wrong and your
> email header has the correct full name.
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: rtl8188eu: Fix static symbol sparse warning
@ 2014-08-05 18:49 Miguel Oliveira
2014-08-05 16:54 ` Fabio Estevam
2014-08-05 16:56 ` Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Miguel Oliveira @ 2014-08-05 18:49 UTC (permalink / raw)
To: gregkh
Cc: navin.patidar, Larry.Finger, oat.elena, paulmck, devel,
linux-kernel, Miguel
From: Miguel <cmroliv@gmail.com>
Fix sparse warning:
drivers/staging/rtl8188eu/core/rtw_cmd.c:52:5: warning: symbol '_rtw_enqueue_cmd' was not declared. Should it be static?
by making it static since it's only used once.
Signed-off-by: Miguel Oliveira <cmroliv@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c b/drivers/staging/rtl8188eu/core/rtw_cmd.c
index 08c325e..104b01f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_cmd.c
+++ b/drivers/staging/rtl8188eu/core/rtw_cmd.c
@@ -49,7 +49,7 @@ ISR/Call-Back functions can't call this sub-function.
*/
-int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj)
+static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj)
{
unsigned long irqL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-05 17:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-05 18:49 [PATCH] staging: rtl8188eu: Fix static symbol sparse warning Miguel Oliveira
2014-08-05 16:54 ` Fabio Estevam
2014-08-05 16:56 ` Dan Carpenter
2014-08-05 17:01 ` Miguel Oliveira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.