From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Hans Wennborg <hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x
Date: Wed, 6 Aug 2014 11:20:25 +0100 [thread overview]
Message-ID: <20140806102025.GE23882@arm.com> (raw)
In-Reply-To: <1407300121-32432-1-git-send-email-hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
On Wed, Aug 06, 2014 at 05:42:01AM +0100, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index ca18d6d..d84f983 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -623,7 +623,7 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev)
>
> if (fsr & FSR_IGN)
> dev_err_ratelimited(smmu->dev,
> - "Unexpected context fault (fsr 0x%u)\n",
> + "Unexpected context fault (fsr 0x%x)\n",
> fsr);
>
> fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0);
Thanks, applied.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Hans Wennborg <hans@hanshq.net>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x
Date: Wed, 6 Aug 2014 11:20:25 +0100 [thread overview]
Message-ID: <20140806102025.GE23882@arm.com> (raw)
In-Reply-To: <1407300121-32432-1-git-send-email-hans@hanshq.net>
On Wed, Aug 06, 2014 at 05:42:01AM +0100, Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
>
> Found by using regex suggested by Joe Perches.
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
> ---
> drivers/iommu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index ca18d6d..d84f983 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -623,7 +623,7 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev)
>
> if (fsr & FSR_IGN)
> dev_err_ratelimited(smmu->dev,
> - "Unexpected context fault (fsr 0x%u)\n",
> + "Unexpected context fault (fsr 0x%x)\n",
> fsr);
>
> fsynr = readl_relaxed(cb_base + ARM_SMMU_CB_FSYNR0);
Thanks, applied.
Will
next prev parent reply other threads:[~2014-08-06 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 4:42 [PATCH 03/15] iommu/arm-smmu: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
[not found] ` <1407300121-32432-1-git-send-email-hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org>
2014-08-06 10:20 ` Will Deacon [this message]
2014-08-06 10:20 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806102025.GE23882@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=hans-7z9IcJk4adCsTnJN9+BGXg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.