From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Mark Salter <msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] UEFI arm64: add noefi boot param
Date: Wed, 6 Aug 2014 15:18:14 +0100 [thread overview]
Message-ID: <20140806141814.GD15082@console-pimps.org> (raw)
In-Reply-To: <CAKv+Gu8ey1iKu-_wS6yYaEXQaQMDXa+PF5Kiw+edA9a_OE1EAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote:
>
> Shouldn't we clear the bit here if we failed to enable runtime
> services for some reason? Other code may test the bit assuming that it
> signifies that runtime services have been enabled successfully, while
> this patch changes it to mean that we /intended/ to enable them, which
> is not quite the same thing.
Yep, good catch. We need to do something similar for efi_runtime_init()
on x86 too.
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] UEFI arm64: add noefi boot param
Date: Wed, 6 Aug 2014 15:18:14 +0100 [thread overview]
Message-ID: <20140806141814.GD15082@console-pimps.org> (raw)
In-Reply-To: <CAKv+Gu8ey1iKu-_wS6yYaEXQaQMDXa+PF5Kiw+edA9a_OE1EAw@mail.gmail.com>
On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote:
>
> Shouldn't we clear the bit here if we failed to enable runtime
> services for some reason? Other code may test the bit assuming that it
> signifies that runtime services have been enabled successfully, while
> this patch changes it to mean that we /intended/ to enable them, which
> is not quite the same thing.
Yep, good catch. We need to do something similar for efi_runtime_init()
on x86 too.
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
Dave Young <dyoung@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Matt Fleming <matt.fleming@intel.com>,
Mark Salter <msalter@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [PATCH 1/2] UEFI arm64: add noefi boot param
Date: Wed, 6 Aug 2014 15:18:14 +0100 [thread overview]
Message-ID: <20140806141814.GD15082@console-pimps.org> (raw)
In-Reply-To: <CAKv+Gu8ey1iKu-_wS6yYaEXQaQMDXa+PF5Kiw+edA9a_OE1EAw@mail.gmail.com>
On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote:
>
> Shouldn't we clear the bit here if we failed to enable runtime
> services for some reason? Other code may test the bit assuming that it
> signifies that runtime services have been enabled successfully, while
> this patch changes it to mean that we /intended/ to enable them, which
> is not quite the same thing.
Yep, good catch. We need to do something similar for efi_runtime_init()
on x86 too.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-08-06 14:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 8:38 [PATCH 1/2] UEFI arm64: add noefi boot param Dave Young
2014-08-06 8:38 ` Dave Young
2014-08-06 12:39 ` Will Deacon
2014-08-06 12:39 ` Will Deacon
2014-08-06 12:40 ` Ard Biesheuvel
2014-08-06 12:40 ` Ard Biesheuvel
2014-08-07 1:28 ` Dave Young
2014-08-07 1:28 ` Dave Young
2014-08-07 7:07 ` Ard Biesheuvel
2014-08-07 7:07 ` Ard Biesheuvel
[not found] ` <20140806083825.GA31711-je1gSBvt1Tc/CGXRbJeUwh/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2014-08-06 13:06 ` Leif Lindholm
2014-08-06 13:06 ` Leif Lindholm
2014-08-06 13:06 ` Leif Lindholm
2014-08-06 13:20 ` Matt Fleming
2014-08-06 13:20 ` Matt Fleming
[not found] ` <20140806132021.GB15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-06 13:29 ` Leif Lindholm
2014-08-06 13:29 ` Leif Lindholm
2014-08-06 13:29 ` Leif Lindholm
[not found] ` <20140806132941.GJ4179-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2014-08-06 14:01 ` Matt Fleming
2014-08-06 14:01 ` Matt Fleming
2014-08-06 14:01 ` Matt Fleming
[not found] ` <20140806140155.GC15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-06 14:10 ` Ard Biesheuvel
2014-08-06 14:10 ` Ard Biesheuvel
2014-08-06 14:10 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8ey1iKu-_wS6yYaEXQaQMDXa+PF5Kiw+edA9a_OE1EAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-06 14:18 ` Matt Fleming [this message]
2014-08-06 14:18 ` Matt Fleming
2014-08-06 14:18 ` Matt Fleming
[not found] ` <20140806141814.GD15082-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-08-06 14:48 ` Leif Lindholm
2014-08-06 14:48 ` Leif Lindholm
2014-08-06 14:48 ` Leif Lindholm
[not found] ` <20140806144839.GK4179-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2014-08-06 14:55 ` Matt Fleming
2014-08-06 14:55 ` Matt Fleming
2014-08-06 14:55 ` Matt Fleming
2014-08-07 6:19 ` Dave Young
2014-08-07 6:19 ` Dave Young
2014-08-07 6:19 ` Dave Young
[not found] ` <20140807061945.GE20295-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-08-07 20:26 ` Matt Fleming
2014-08-07 20:26 ` Matt Fleming
2014-08-07 20:26 ` Matt Fleming
2014-08-11 9:00 ` Dave Young
2014-08-11 9:00 ` Dave Young
2014-08-07 1:27 ` Dave Young
2014-08-07 1:27 ` Dave Young
[not found] ` <20140807012708.GA20295-4/PLUo9XfK+sDdueE5tM26fLeoKvNuZc@public.gmane.org>
2014-08-07 20:09 ` Matt Fleming
2014-08-07 20:09 ` Matt Fleming
2014-08-07 20:09 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806141814.GD15082@console-pimps.org \
--to=matt-hnk1s37rvnbexh+ff434mdi2o/jbrioy@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.