From: Josh Triplett <josh@joshtriplett.org>
To: Nick Krause <xerofoiify@gmail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
"open list:SUPERH" <linux-sh@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: bug: add unreachable() to silence warnings
Date: Thu, 07 Aug 2014 05:10:20 +0000 [thread overview]
Message-ID: <20140807051020.GB2340@thin> (raw)
In-Reply-To: <1407375741-3209-1-git-send-email-xerofoiify@gmail.com>
On Thu, Aug 07, 2014 at 03:42:20AM +0200, Nick Krause wrote:
> SuperH BUG() have warnings like
>
> kernel/sched/core.c:2692:1: warning: control reaches end of non-void function
> [-Wreturn-type]
> net/core/ethtool.c:236:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>
> Other BUG() implementations
> have added unreachable() at end becuase of which I guess
> it does not showthese errors. We can silence them using unreachable().
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
This change seems reasonable to me. Unlike the generic version of
BUG(), this one doesn't call panic() or anything else flagged as
__noreturn, so it seems reasonable to add a call to unreachable() here
to tell the compiler that the assembly will trap and not return.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> arch/sh/include/asm/bug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/include/asm/bug.h b/arch/sh/include/asm/bug.h
> index dcf2780..1ae948f 100644
> --- a/arch/sh/include/asm/bug.h
> +++ b/arch/sh/include/asm/bug.h
> @@ -48,6 +48,7 @@ do { \
> "i" (__FILE__), \
> "i" (__LINE__), "i" (0), \
> "i" (sizeof(struct bug_entry))); \
> + unreachable(); \
> } while (0)
>
> #define __WARN_TAINT(taint) \
> --
> 2.0.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Josh Triplett <josh@joshtriplett.org>
To: Nick Krause <xerofoiify@gmail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms+renesas@verge.net.au>,
"open list:SUPERH" <linux-sh@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: bug: add unreachable() to silence warnings
Date: Wed, 6 Aug 2014 22:10:20 -0700 [thread overview]
Message-ID: <20140807051020.GB2340@thin> (raw)
In-Reply-To: <1407375741-3209-1-git-send-email-xerofoiify@gmail.com>
On Thu, Aug 07, 2014 at 03:42:20AM +0200, Nick Krause wrote:
> SuperH BUG() have warnings like
>
> kernel/sched/core.c:2692:1: warning: control reaches end of non-void function
> [-Wreturn-type]
> net/core/ethtool.c:236:1: warning: control reaches end of non-void function
> [-Wreturn-type]
>
> Other BUG() implementations
> have added unreachable() at end becuase of which I guess
> it does not showthese errors. We can silence them using unreachable().
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
This change seems reasonable to me. Unlike the generic version of
BUG(), this one doesn't call panic() or anything else flagged as
__noreturn, so it seems reasonable to add a call to unreachable() here
to tell the compiler that the assembly will trap and not return.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> arch/sh/include/asm/bug.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/include/asm/bug.h b/arch/sh/include/asm/bug.h
> index dcf2780..1ae948f 100644
> --- a/arch/sh/include/asm/bug.h
> +++ b/arch/sh/include/asm/bug.h
> @@ -48,6 +48,7 @@ do { \
> "i" (__FILE__), \
> "i" (__LINE__), "i" (0), \
> "i" (sizeof(struct bug_entry))); \
> + unreachable(); \
> } while (0)
>
> #define __WARN_TAINT(taint) \
> --
> 2.0.1
>
next prev parent reply other threads:[~2014-08-07 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 1:42 [PATCH] sh: bug: add unreachable() to silence warnings Nick Krause
2014-08-07 1:42 ` Nick Krause
2014-08-07 5:10 ` Josh Triplett [this message]
2014-08-07 5:10 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807051020.GB2340@thin \
--to=josh@joshtriplett.org \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=xerofoiify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.