From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, b42378@freescale.com,
b02247@freescale.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, timur@tabi.org,
Nicolin Chen <nicoleotsuka@gmail.com>,
Li.Xiubo@freescale.com, galak@codeaurora.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support
Date: Thu, 7 Aug 2014 17:44:05 +0800 [thread overview]
Message-ID: <20140807094404.GB3088@MrMyself> (raw)
In-Reply-To: <20140807094527.GC17528@sirena.org.uk>
On Thu, Aug 07, 2014 at 10:45:27AM +0100, Mark Brown wrote:
> On Tue, Aug 05, 2014 at 03:32:05PM +0800, Nicolin Chen wrote:
> > From: Nicolin Chen <Guangyu.Chen@freescale.com>
> >
> > SAI supports these operation modes:
> > 1) asynchronous mode
> > Both Tx and Rx are set to be asynchronous.
> > 2) synchronous mode (Rx sync with Tx)
> > Tx is set to be asynchronous, Rx is set to be synchronous.
> > 3) synchronous mode (Tx sync with Rx)
> > Rx is set to be asynchronous, Tx is set to be synchronous.
> > 4) synchronous mode (Tx/Rx sync with another SAI's Tx)
> > 5) synchronous mode (Tx/Rx sync with another SAI's Rx)
>
> This seems to conflict with something else on my branch - not checked
> what. Can you take a look please?
Ah...there is another patch that should haven been merged into for-next
is currently missing on the remote branch.
This one:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/079689.html
> > +Note:
> > +- If both fsl,sai-asynchronous and fsl,sai-synchronous-rx are absent, the
> > + default synchronous mode (sync Rx with Tx) will be used, which means both
> > + transimitter and receiver will send and receive data by following clocks
> > + of transimitter.
> > +- fsl,sai-asynchronous will be ignored if fsl,sai-synchronous-rx property is
> > + already present.
>
> Might be worth printing an error here.
Hmm...Do I need to send a v2?
Thank you
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
<linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<alsa-devel@alsa-project.org>, <timur@tabi.org>,
<Li.Xiubo@freescale.com>, <devicetree@vger.kernel.org>,
<galak@codeaurora.org>, <ijc+devicetree@hellion.org.uk>,
<mark.rutland@arm.com>, <pawel.moll@arm.com>,
<robh+dt@kernel.org>, <b42378@freescale.com>,
<b02247@freescale.com>
Subject: Re: [PATCH] ASoC: fsl_sai: Add asynchronous mode support
Date: Thu, 7 Aug 2014 17:44:05 +0800 [thread overview]
Message-ID: <20140807094404.GB3088@MrMyself> (raw)
In-Reply-To: <20140807094527.GC17528@sirena.org.uk>
On Thu, Aug 07, 2014 at 10:45:27AM +0100, Mark Brown wrote:
> On Tue, Aug 05, 2014 at 03:32:05PM +0800, Nicolin Chen wrote:
> > From: Nicolin Chen <Guangyu.Chen@freescale.com>
> >
> > SAI supports these operation modes:
> > 1) asynchronous mode
> > Both Tx and Rx are set to be asynchronous.
> > 2) synchronous mode (Rx sync with Tx)
> > Tx is set to be asynchronous, Rx is set to be synchronous.
> > 3) synchronous mode (Tx sync with Rx)
> > Rx is set to be asynchronous, Tx is set to be synchronous.
> > 4) synchronous mode (Tx/Rx sync with another SAI's Tx)
> > 5) synchronous mode (Tx/Rx sync with another SAI's Rx)
>
> This seems to conflict with something else on my branch - not checked
> what. Can you take a look please?
Ah...there is another patch that should haven been merged into for-next
is currently missing on the remote branch.
This one:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-August/079689.html
> > +Note:
> > +- If both fsl,sai-asynchronous and fsl,sai-synchronous-rx are absent, the
> > + default synchronous mode (sync Rx with Tx) will be used, which means both
> > + transimitter and receiver will send and receive data by following clocks
> > + of transimitter.
> > +- fsl,sai-asynchronous will be ignored if fsl,sai-synchronous-rx property is
> > + already present.
>
> Might be worth printing an error here.
Hmm...Do I need to send a v2?
Thank you
Nicolin
next prev parent reply other threads:[~2014-08-07 9:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 7:32 [PATCH] ASoC: fsl_sai: Add asynchronous mode support Nicolin Chen
2014-08-05 7:32 ` Nicolin Chen
2014-08-05 7:32 ` Nicolin Chen
2014-08-05 10:59 ` Varka Bhadram
2014-08-05 10:59 ` Varka Bhadram
2014-08-05 11:07 ` Nicolin Chen
2014-08-05 11:07 ` Nicolin Chen
2014-08-05 11:07 ` Nicolin Chen
2014-08-05 11:14 ` Varka Bhadram
2014-08-05 11:14 ` Varka Bhadram
2014-08-05 11:14 ` Varka Bhadram
[not found] ` <53E0BC95.7040208-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 2:42 ` Nicolin Chen
2014-08-06 2:42 ` Nicolin Chen
2014-08-06 2:42 ` Nicolin Chen
2014-08-06 20:12 ` Mark Brown
2014-08-06 20:12 ` Mark Brown
2014-08-06 20:12 ` Mark Brown
2014-08-07 9:45 ` Mark Brown
2014-08-07 9:45 ` Mark Brown
2014-08-07 9:44 ` Nicolin Chen [this message]
2014-08-07 9:44 ` Nicolin Chen
2014-08-07 10:05 ` Mark Brown
2014-08-07 10:05 ` Mark Brown
2014-08-07 10:05 ` Mark Brown
[not found] ` <1407223925-29678-1-git-send-email-nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-07 11:19 ` Mark Brown
2014-08-07 11:19 ` Mark Brown
2014-08-07 11:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807094404.GB3088@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=b02247@freescale.com \
--cc=b42378@freescale.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=nicoleotsuka@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.