From: Lee Jones <lee.jones@linaro.org>
To: Gyungoh Yoo <gyungoh@gmail.com>
Cc: rdunlap@infradead.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, jg1.han@samsung.com, cooloney@gmail.com,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
grant.likely@linaro.org, sameo@linux.intel.com,
lgirdwood@gmail.com, broonie@kernel.org,
jack.yoo@skyworksinc.com, florian.vaussard@epfl.ch,
thierry.reding@gmail.com, jason@lakedaemon.net, andrew@lunn.ch,
silvio.fricke@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Adding a support for Skyworks SKY81452
Date: Thu, 07 Aug 2014 10:09:52 +0000 [thread overview]
Message-ID: <20140807100952.GH10136@lee--X1> (raw)
In-Reply-To: <1407398738-7582-1-git-send-email-jack.yoo@skyworksinc.com>
On Thu, 07 Aug 2014, Gyungoh Yoo wrote:
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> ---
> Documentation/backlight/sky81452.txt | 25 ++
> Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++
> .../bindings/regulator/sky81452-regulator.txt | 16 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> .../video/backlight/sky81452-backlight.txt | 20 ++
> drivers/mfd/Kconfig | 12 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/sky81452.c | 115 +++++++
> drivers/regulator/Kconfig | 11 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/sky81452-regulator.c | 127 ++++++++
> drivers/video/backlight/Kconfig | 10 +
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/sky81452-backlight.c | 333 +++++++++++++++++++++
> include/linux/mfd/sky81452.h | 31 ++
> include/linux/sky81452-backlight.h | 46 +++
> 16 files changed, 774 insertions(+)
> create mode 100644 Documentation/backlight/sky81452.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/sky81452-regulator.txt
> create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> create mode 100644 drivers/mfd/sky81452.c
> create mode 100644 drivers/regulator/sky81452-regulator.c
> create mode 100644 drivers/video/backlight/sky81452-backlight.c
> create mode 100644 include/linux/mfd/sky81452.h
> create mode 100644 include/linux/sky81452-backlight.h
Wow, no way. Please split this up into separate patches. Ideally, at
least one per subsystem and separate ones again for the DT bindings.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Gyungoh Yoo <gyungoh@gmail.com>
Cc: rdunlap@infradead.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, jg1.han@samsung.com, cooloney@gmail.com,
plagnioj@jcrosoft.com, tomi.valkeinen@ti.com,
grant.likely@linaro.org, sameo@linux.intel.com,
lgirdwood@gmail.com, broonie@kernel.org,
jack.yoo@skyworksinc.com, florian.vaussard@epfl.ch,
thierry.reding@gmail.com, jason@lakedaemon.net, andrew@lunn.ch,
silvio.fricke@gmail.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] Adding a support for Skyworks SKY81452
Date: Thu, 7 Aug 2014 11:09:52 +0100 [thread overview]
Message-ID: <20140807100952.GH10136@lee--X1> (raw)
In-Reply-To: <1407398738-7582-1-git-send-email-jack.yoo@skyworksinc.com>
On Thu, 07 Aug 2014, Gyungoh Yoo wrote:
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> ---
> Documentation/backlight/sky81452.txt | 25 ++
> Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++
> .../bindings/regulator/sky81452-regulator.txt | 16 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> .../video/backlight/sky81452-backlight.txt | 20 ++
> drivers/mfd/Kconfig | 12 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/sky81452.c | 115 +++++++
> drivers/regulator/Kconfig | 11 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/sky81452-regulator.c | 127 ++++++++
> drivers/video/backlight/Kconfig | 10 +
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/sky81452-backlight.c | 333 +++++++++++++++++++++
> include/linux/mfd/sky81452.h | 31 ++
> include/linux/sky81452-backlight.h | 46 +++
> 16 files changed, 774 insertions(+)
> create mode 100644 Documentation/backlight/sky81452.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/sky81452.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/sky81452-regulator.txt
> create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> create mode 100644 drivers/mfd/sky81452.c
> create mode 100644 drivers/regulator/sky81452-regulator.c
> create mode 100644 drivers/video/backlight/sky81452-backlight.c
> create mode 100644 include/linux/mfd/sky81452.h
> create mode 100644 include/linux/sky81452-backlight.h
Wow, no way. Please split this up into separate patches. Ideally, at
least one per subsystem and separate ones again for the DT bindings.
[...]
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-07 10:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 8:05 [PATCH] Adding a support for Skyworks SKY81452 Gyungoh Yoo
2014-08-07 8:05 ` Gyungoh Yoo
2014-08-07 10:09 ` Lee Jones [this message]
2014-08-07 10:09 ` Lee Jones
2014-08-08 6:22 ` Gyungoh Yoo
2014-08-08 6:22 ` Gyungoh Yoo
2014-08-07 12:34 ` Tobias Klauser
2014-08-07 12:34 ` Tobias Klauser
2014-08-08 6:24 ` Gyungoh Yoo
2014-08-08 6:24 ` Gyungoh Yoo
2014-08-08 7:09 ` Thierry Reding
2014-08-08 7:09 ` Thierry Reding
2014-08-08 7:20 ` Tobias Klauser
2014-08-08 7:20 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807100952.GH10136@lee--X1 \
--to=lee.jones@linaro.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=silvio.fricke@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.