From: Will Deacon <will.deacon@arm.com>
To: Nick Krause <xerofoiify@gmail.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
Linus Walleij <linus.walleij@linaro.org>,
Ben Boeckel <mathstuf@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] smsc: Undefine SMC_inb and SMC_outb before define
Date: Thu, 7 Aug 2014 13:55:57 +0100 [thread overview]
Message-ID: <20140807125557.GL13703@arm.com> (raw)
In-Reply-To: <1407392942-22183-1-git-send-email-xerofoiify@gmail.com>
On Thu, Aug 07, 2014 at 07:29:00AM +0100, Nick Krause wrote:
> Undefine SMC_inb and SMC_outb before redifing to prevent warning which follows
>
> drivers/net/ethernet/smsc/smc91x.h:490:0: warning: "SMC_inb" redefined [enabled by default]
> drivers/net/ethernet/smsc/smc91x.h:199:0: note: this is the location of the previous definition
> drivers/net/ethernet/smsc/smc91x.h:491:0: warning: "SMC_outb" redefined [enabled by default]
> drivers/net/ethernet/smsc/smc91x.h:201:0: note: this is the location of the previous definition
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/smsc/smc91x.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.h b/drivers/net/ethernet/smsc/smc91x.h
> index 47dce91..d1c5441 100644
> --- a/drivers/net/ethernet/smsc/smc91x.h
> +++ b/drivers/net/ethernet/smsc/smc91x.h
> @@ -487,6 +487,8 @@ smc_pxa_dma_irq(int dma, void *dummy)
> #endif
>
> #if ! SMC_CAN_USE_8BIT
> +#undef SMC_inb
> +#undef SMC_outb
> #define SMC_inb(ioaddr, reg) ({ BUG(); 0; })
> #define SMC_outb(x, ioaddr, reg) BUG()
> #define SMC_insb(a, r, p, l) BUG()
Nak. The real issue here appears to be that the CONFIG_M32R code defines
SMC_CAN_USE_8BIT as 0 but then defines SMC_inb/SMC_outb anyway.
Will
parent reply other threads:[~2014-08-07 12:56 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1407392942-22183-1-git-send-email-xerofoiify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807125557.GL13703@arm.com \
--to=will.deacon@arm.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathstuf@gmail.com \
--cc=michael.opdenacker@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=xerofoiify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.