* Re: [PATCH] smsc: Undefine SMC_inb and SMC_outb before define
[not found] <1407392942-22183-1-git-send-email-xerofoiify@gmail.com>
@ 2014-08-07 12:55 ` Will Deacon
0 siblings, 0 replies; only message in thread
From: Will Deacon @ 2014-08-07 12:55 UTC (permalink / raw)
To: Nick Krause
Cc: Nicolas Pitre, David S. Miller, Linus Walleij, Ben Boeckel,
Jeff Kirsher, Michael Opdenacker, open list:NETWORKING DRIVERS,
open list
On Thu, Aug 07, 2014 at 07:29:00AM +0100, Nick Krause wrote:
> Undefine SMC_inb and SMC_outb before redifing to prevent warning which follows
>
> drivers/net/ethernet/smsc/smc91x.h:490:0: warning: "SMC_inb" redefined [enabled by default]
> drivers/net/ethernet/smsc/smc91x.h:199:0: note: this is the location of the previous definition
> drivers/net/ethernet/smsc/smc91x.h:491:0: warning: "SMC_outb" redefined [enabled by default]
> drivers/net/ethernet/smsc/smc91x.h:201:0: note: this is the location of the previous definition
>
> Signed-off-by: Nick Krause <xerofoify@gmail.com>
> ---
> drivers/net/ethernet/smsc/smc91x.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.h b/drivers/net/ethernet/smsc/smc91x.h
> index 47dce91..d1c5441 100644
> --- a/drivers/net/ethernet/smsc/smc91x.h
> +++ b/drivers/net/ethernet/smsc/smc91x.h
> @@ -487,6 +487,8 @@ smc_pxa_dma_irq(int dma, void *dummy)
> #endif
>
> #if ! SMC_CAN_USE_8BIT
> +#undef SMC_inb
> +#undef SMC_outb
> #define SMC_inb(ioaddr, reg) ({ BUG(); 0; })
> #define SMC_outb(x, ioaddr, reg) BUG()
> #define SMC_insb(a, r, p, l) BUG()
Nak. The real issue here appears to be that the CONFIG_M32R code defines
SMC_CAN_USE_8BIT as 0 but then defines SMC_inb/SMC_outb anyway.
Will
^ permalink raw reply [flat|nested] only message in thread