Re: [PATCH] drm/panel/simple: add optronics B101XTN01.0

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2527 bytes --]

On Thu, Aug 07, 2014 at 08:50:22AM -0400, Rob Clark wrote:
> On Thu, Aug 7, 2014 at 3:33 AM, Thierry Reding <thierry.reding@gmail.com> wrote:
> > On Wed, Aug 06, 2014 at 04:31:30PM -0400, Rob Clark wrote:
> >> LVDS panel, make/model described as:
> >>
> >> AU Optronics Corporation - B101XTN01.0 (H/W:0A)
> >>
> >> See:
> >> http://www.encore-electronic.com/media/B101XTN01.0.pdf
> >
> > I've made it a custom to mention which board a panel is used on in the
> > commit message and I've requested others to do the same. The idea was
> > that it would give some kind of indication where to find the hardware if
> > somebody wanted to test or look at for reference.
> 
> It's just a free-standing panel, which (in this case) can be plugged
> to an ifc6410 (and I think various other inforce boards..) looks like
> a standard(ish) 41 pin connector.

Well, it certainly doesn't have to be exclusively used on a board. I
guess if it isn't shipped with the IFC6410 as standard, maybe you could
simply mention that it's been tested on an IFC6410.

What I like to avoid is that people submit panel patches that are not
tested on real hardware.

> >> Signed-off-by: Rob Clark <robdclark@gmail.com>
> >> ---
> >>  drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> >>  1 file changed, 27 insertions(+)
> >
> > This is missing device tree binding documentation.
> 
> there is nothing new, so I assume you just mean adding the compatible
> string to a list?

There's no such list. You should add a new file, named after the
compatible string and stick it along with all the others into
Documentation/devicetree/bindings/panel. You can simply use one of the
other bindings that are derived from simple-panel as template and adjust
for the panel-specifics. There are a couple from AUO in that directory
already, so it should be easy.

> >>  static const struct of_device_id platform_of_match[] = {
> >>       {
> >>               .compatible = "auo,b101aw03",
> >> @@ -476,6 +499,10 @@ static const struct of_device_id platform_of_match[] = {
> >>               .compatible = "samsung,ltn101nt05",
> >>               .data = &samsung_ltn101nt05,
> >>       }, {
> >> +             .compatible = "optronics,b101xtn01",
> >
> > From the commit message this panel is from AU Optronics, so it should
> > use the auo vendor prefix.
> 
> so, "auo,b101xtn01" works for everyone?

Yeah, that's consistent with the other ones from AUO, so looking good to
me.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel