From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org
Subject: Re: [PATCH v3 2/8] spi: sun4i: add DMA support
Date: Thu, 7 Aug 2014 18:44:42 +0100 [thread overview]
Message-ID: <20140807174442.GP17528@sirena.org.uk> (raw)
In-Reply-To: <1407183002-29420-3-git-send-email-emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
On Mon, Aug 04, 2014 at 05:09:56PM -0300, Emilio López wrote:
> +static int sun4i_spi_prepare_message(struct spi_master *master,
> + struct spi_message *msg)
> +{
> + struct sun4i_spi *sspi = spi_master_get_devdata(master);
> +
> + master->dma_rx = sspi->rx_dma_chan;
> + master->dma_tx = sspi->tx_dma_chan;
> +
> + return 0;
> +}
Why is this being done per transfer rather than at probe time?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/8] spi: sun4i: add DMA support
Date: Thu, 7 Aug 2014 18:44:42 +0100 [thread overview]
Message-ID: <20140807174442.GP17528@sirena.org.uk> (raw)
In-Reply-To: <1407183002-29420-3-git-send-email-emilio@elopez.com.ar>
On Mon, Aug 04, 2014 at 05:09:56PM -0300, Emilio L?pez wrote:
> +static int sun4i_spi_prepare_message(struct spi_master *master,
> + struct spi_message *msg)
> +{
> + struct sun4i_spi *sspi = spi_master_get_devdata(master);
> +
> + master->dma_rx = sspi->rx_dma_chan;
> + master->dma_tx = sspi->tx_dma_chan;
> +
> + return 0;
> +}
Why is this being done per transfer rather than at probe time?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140807/930f5ba3/attachment.sig>
next prev parent reply other threads:[~2014-08-07 17:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 20:09 [PATCH v3 0/8] DMAEngine support for sun4i, sun5i & sun7i Emilio López
2014-08-04 20:09 ` Emilio López
[not found] ` <1407183002-29420-1-git-send-email-emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
2014-08-04 20:09 ` [PATCH v3 1/8] dma: sun4i: Add support for the DMA engine on sun[457]i SoCs Emilio López
2014-08-04 20:09 ` Emilio López
[not found] ` <1407183002-29420-2-git-send-email-emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
2014-08-05 20:00 ` Maxime Ripard
2014-08-05 20:00 ` Maxime Ripard
2014-08-07 19:37 ` Emilio López
2014-08-07 19:37 ` Emilio López
[not found] ` <53E3D56C.5030204-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
2014-08-09 15:11 ` jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
2014-08-09 15:11 ` jonsmirl at gmail.com
2014-08-11 11:40 ` Maxime Ripard
2014-08-11 11:40 ` Maxime Ripard
2014-08-11 12:36 ` jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
2014-08-11 12:36 ` jonsmirl at gmail.com
2014-08-04 20:09 ` [PATCH v3 2/8] spi: sun4i: add DMA support Emilio López
2014-08-04 20:09 ` Emilio López
[not found] ` <1407183002-29420-3-git-send-email-emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
2014-08-05 20:23 ` Maxime Ripard
2014-08-05 20:23 ` Maxime Ripard
2014-08-07 20:37 ` Emilio López
2014-08-07 20:37 ` Emilio López
2014-08-07 17:44 ` Mark Brown [this message]
2014-08-07 17:44 ` Mark Brown
2014-08-04 20:09 ` [PATCH v3 3/8] ARM: sun4i: dt: Add node to represent the DMA controller Emilio López
2014-08-04 20:09 ` Emilio López
[not found] ` <1407183002-29420-4-git-send-email-emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>
2014-08-05 20:25 ` Maxime Ripard
2014-08-05 20:25 ` Maxime Ripard
2014-08-04 20:09 ` [PATCH v3 4/8] ARM: sun5i: dt: Add nodes to represent the DMA controllers Emilio López
2014-08-04 20:09 ` Emilio López
2014-08-04 20:09 ` [PATCH v3 5/8] ARM: sun7i: dt: Add node to represent the DMA controller Emilio López
2014-08-04 20:09 ` Emilio López
2014-08-04 20:10 ` [PATCH v3 6/8] ARM: sun4i: dt: enable DMA on SPI Emilio López
2014-08-04 20:10 ` Emilio López
2014-08-04 20:10 ` [PATCH v3 7/8] ARM: sun5i: " Emilio López
2014-08-04 20:10 ` Emilio López
2014-08-04 20:10 ` [PATCH v3 8/8] ARM: sun7i: " Emilio López
2014-08-04 20:10 ` Emilio López
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807174442.GP17528@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org \
--cc=kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
--cc=sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.