From: Dan Carpenter <dan.carpenter@oracle.com>
To: Adrian Remonda <adrianremonda@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
Subject: Re: [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code.
Date: Fri, 8 Aug 2014 12:05:38 +0300 [thread overview]
Message-ID: <20140808090538.GH4856@mwanda> (raw)
In-Reply-To: <1407447471-11632-2-git-send-email-adrianremonda@gmail.com>
On Thu, Aug 07, 2014 at 11:37:51PM +0200, Adrian Remonda wrote:
> This patch clear some code that was not doing any help.
> Pointed out by Larry.Finger
>
The patch is fine but the changelog doesn't inpsire confidence. It
should say:
This patch removes some unneeded code.
1) kzalloc() allocates 4 extra bytes so that we can align the return
value. But actually the return value is already aligned so we can
remove the + 4 and the call to N_BYTE_ALIGMENT().
2) The memset() isn't needed because kzalloc() zeroes the allocation.
Suggested-by: Larry Finger <Larry.Finger@lwfinger.net>
regards,
dan carpenter
next prev parent reply other threads:[~2014-08-08 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 21:37 [PATCHv2 1/2] Staging: rtl8188eu: Lines over 80 characters fixed Adrian Remonda
2014-08-07 21:37 ` [PATCHv2 2/2] Staging: rtl8188eu: Removed unnecessarry code Adrian Remonda
2014-08-08 9:05 ` Dan Carpenter [this message]
2014-08-10 4:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808090538.GH4856@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=adrianremonda@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.