All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: soft-lockups in sunvnet
Date: Fri, 08 Aug 2014 20:47:55 +0000	[thread overview]
Message-ID: <20140808204755.GB24555@oracle.com> (raw)
In-Reply-To: <20140808.114601.1454008888717150216.davem@davemloft.net>

On (08/08/14 12:59), David Miller wrote:
> 
> This only works because we free the packet in the ->ndo_start_xmit()
> method.  If we didn't do that, and we freed it up at ACK time, we'd
> need to force the ACKs in order to guarentee that we release the SKB
> in a finite amount of time.
> 

I see. I missed that subtlety. I'll make a note in the comments for
my proposed change, in case this piece of code changes in the future.

--Sowmini


  parent reply	other threads:[~2014-08-08 20:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 18:46 soft-lockups in sunvnet David Miller
2014-08-08 18:55 ` Sowmini Varadhan
2014-08-08 19:59 ` David Miller
2014-08-08 20:47 ` Sowmini Varadhan [this message]
2014-08-10 19:56 ` Sowmini Varadhan
2014-08-11 20:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140808204755.GB24555@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.