From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: sparclinux@vger.kernel.org
Subject: Re: soft-lockups in sunvnet
Date: Sun, 10 Aug 2014 19:56:22 +0000 [thread overview]
Message-ID: <20140810195622.GA11770@oracle.com> (raw)
In-Reply-To: <20140808.114601.1454008888717150216.davem@davemloft.net>
To wrap up this thread..
I just sent out a tentative patch with the first round of fixes
to netdev. These fixes take care of the bare minimum of making
sure we don't soft-lockup when the sink does not receive packets.
I can still see at least 2 areas of improvement, that I'd like
to address separately, since the changes are non-trivial and
have to be done carefully
1. finer granularity of flow-control in vnet_start_xmit(): instead
of doing a netif_stop_queue() when any single peer is congested,
try to track flow-control for that peer only, and let the others
continue Tx/Rx
2. better recovery from vnet_send_ack() failure: I have a somewhat
odd printk there today, just to let the admin know that help
is needed. I've tried calling ldc_disconnect() here, but it
doesn't really reset the peer, though a module-reload fixes it.
So what's needed is to trigger just the unregister/register of
the problematic port, and this will need more than a few lines
of change (I think it has to be triggered by ds?)
I'll take a look at those two over the next few weeks, but didnt
want to hold up these changes hostage while that's happening.
--Sowmini
next prev parent reply other threads:[~2014-08-10 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 18:46 soft-lockups in sunvnet David Miller
2014-08-08 18:55 ` Sowmini Varadhan
2014-08-08 19:59 ` David Miller
2014-08-08 20:47 ` Sowmini Varadhan
2014-08-10 19:56 ` Sowmini Varadhan [this message]
2014-08-11 20:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140810195622.GA11770@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.