Re: Atmel at86rf212 and 'b' support in Linux

Re: Atmel at86rf212 and 'b' support in Linux

[Alexander Aring]

On Fri, Aug 08, 2014 at 02:58:21PM -0700, Andrey Yurovsky wrote:
> Hi Alex.  I'm working with the at86rf212b and we're using the
> at86rf230.c from mainline.  There's a version check there that
> specifically rejects anything except version 1:
> 
>         case 7:
>                 chip = "at86rf212";
>                 if (version == 1) {
>                         lp->data = &at86rf212_data;
>                         lp->dev->flags |= IEEE802154_HW_LBT;
>                         lp->dev->phy->channels_supported[0] = 0x00007FF;
>                         lp->dev->phy->channels_supported[2] = 0x00007FF;
>                 } else {
>                         rc = -ENOTSUPP;
>                 }
>                 break;
> 
> ...and our hardware returns version 3.  I've removed this check and
> things seem to work and I've also discussed it with two Atmel FAEs and
> they don't see any reason for this check to be performed or for the
> driver to have different behavior for the different revisions (they're
> going to send me a change list for the HW either way).
> 
> Do you know more about this?  Is there a specific issue this check is
> trying to address?  If not, would you mind if I submitted a patch that
> removes it?
> 

This is there because nobody tested the driver with another version than
1. If you tested it, please send patches. There is no other reason why
we check on version 1 there. If nobody tested it, you can never be sure
it's working then.

- Alex