From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Kiran Padwal <kiran.padwal21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] pinctrl: tegra114: Make of_device_id array const
Date: Mon, 11 Aug 2014 15:43:58 +0200 [thread overview]
Message-ID: <20140811134356.GC26128@ulmo.nvidia.com> (raw)
In-Reply-To: <1407755870-439-1-git-send-email-kiran.padwal21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
On Mon, Aug 11, 2014 at 04:47:50PM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const.
>
> Signed-off-by: Kiran Padwal <kiran.padwal21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/pinctrl/pinctrl-tegra114.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-tegra114.c b/drivers/pinctrl/pinctrl-tegra114.c
> index 33614ba..a3db85b 100644
> --- a/drivers/pinctrl/pinctrl-tegra114.c
> +++ b/drivers/pinctrl/pinctrl-tegra114.c
> @@ -1850,7 +1850,7 @@ static int tegra114_pinctrl_probe(struct platform_device *pdev)
> return tegra_pinctrl_probe(pdev, &tegra114_pinctrl);
> }
>
> -static struct of_device_id tegra114_pinctrl_of_match[] = {
> +static const struct of_device_id tegra114_pinctrl_of_match[] = {
> { .compatible = "nvidia,tegra114-pinmux", },
> { },
> };
Good catch, thanks.
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Kiran Padwal <kiran.padwal21@gmail.com>
Cc: swarren@wwwdotorg.org, linus.walleij@linaro.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: tegra114: Make of_device_id array const
Date: Mon, 11 Aug 2014 15:43:58 +0200 [thread overview]
Message-ID: <20140811134356.GC26128@ulmo.nvidia.com> (raw)
In-Reply-To: <1407755870-439-1-git-send-email-kiran.padwal21@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Mon, Aug 11, 2014 at 04:47:50PM +0530, Kiran Padwal wrote:
> Make of_device_id array const, because all OF functions handle it as const.
>
> Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
> ---
> drivers/pinctrl/pinctrl-tegra114.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-tegra114.c b/drivers/pinctrl/pinctrl-tegra114.c
> index 33614ba..a3db85b 100644
> --- a/drivers/pinctrl/pinctrl-tegra114.c
> +++ b/drivers/pinctrl/pinctrl-tegra114.c
> @@ -1850,7 +1850,7 @@ static int tegra114_pinctrl_probe(struct platform_device *pdev)
> return tegra_pinctrl_probe(pdev, &tegra114_pinctrl);
> }
>
> -static struct of_device_id tegra114_pinctrl_of_match[] = {
> +static const struct of_device_id tegra114_pinctrl_of_match[] = {
> { .compatible = "nvidia,tegra114-pinmux", },
> { },
> };
Good catch, thanks.
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-11 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 11:17 [PATCH] pinctrl: tegra114: Make of_device_id array const Kiran Padwal
2014-08-11 11:17 ` Kiran Padwal
[not found] ` <1407755870-439-1-git-send-email-kiran.padwal21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-11 13:43 ` Thierry Reding [this message]
2014-08-11 13:43 ` Thierry Reding
2014-08-28 13:21 ` Linus Walleij
2014-08-28 13:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140811134356.GC26128@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=kiran.padwal21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.