From: Dan Carpenter <dan.carpenter@oracle.com>
To: Roger <rogerable@realtek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn
Subject: Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response
Date: Wed, 13 Aug 2014 11:50:24 +0300 [thread overview]
Message-ID: <20140813085024.GQ11899@mwanda> (raw)
In-Reply-To: <53E9BFF0.5030506@realtek.com>
On Tue, Aug 12, 2014 at 03:19:12PM +0800, Roger wrote:
> I can remove the unused rsp_len in this function. But I'm afraid the
> loop is still required. The destination cmd->resp is cpu-endian, but
> the raw response from SD card in the buffer (pointed by ptr) is
> big-endian.
Oh, yes. Of course. Sorry for the noise.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Roger <rogerable@realtek.com>
Cc: Chris Ball <chris@printf.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
wei_wang@realsil.com.cn
Subject: Re: [PATCH] mmc: rtsx: fix incorrect last byte in R2 response
Date: Wed, 13 Aug 2014 11:50:24 +0300 [thread overview]
Message-ID: <20140813085024.GQ11899@mwanda> (raw)
In-Reply-To: <53E9BFF0.5030506@realtek.com>
On Tue, Aug 12, 2014 at 03:19:12PM +0800, Roger wrote:
> I can remove the unused rsp_len in this function. But I'm afraid the
> loop is still required. The destination cmd->resp is cpu-endian, but
> the raw response from SD card in the buffer (pointed by ptr) is
> big-endian.
Oh, yes. Of course. Sorry for the noise.
regards,
dan carpenter
next prev parent reply other threads:[~2014-08-13 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 8:32 [PATCH] mmc: rtsx: fix incorrect last byte in R2 response rogerable
2014-08-11 8:32 ` rogerable
2014-08-11 13:02 ` Dan Carpenter
2014-08-11 13:02 ` Dan Carpenter
2014-08-12 7:19 ` Roger
2014-08-12 7:19 ` Roger
2014-08-13 8:50 ` Dan Carpenter [this message]
2014-08-13 8:50 ` Dan Carpenter
2014-08-13 15:09 ` Ulf Hansson
2014-08-13 15:09 ` Ulf Hansson
2014-08-14 6:06 ` Roger Tseng
2014-08-14 6:06 ` Roger Tseng
2014-08-14 9:32 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813085024.GQ11899@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@printf.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.