From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: Move i915_gem_chipset_flush to where it belongs
Date: Wed, 13 Aug 2014 14:23:14 +0200 [thread overview]
Message-ID: <20140813122314.GY10500@phenom.ffwll.local> (raw)
In-Reply-To: <20140813114511.GC10052@nuc-i3427.alporthouse.com>
On Wed, Aug 13, 2014 at 12:45:11PM +0100, Chris Wilson wrote:
> On Wed, Aug 13, 2014 at 01:32:31PM +0200, Daniel Vetter wrote:
> > On Wed, Aug 13, 2014 at 11:51:55AM +0100, Chris Wilson wrote:
> > > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >
> > > That's right, back to where it was!
> > >
> > > This effectively reverts
> >
> > Hm, why?
>
> Becuase it doesn't belong in i915_gem_gtt.c since the flush is not about
> flushing the GGTT and it is not used in i915_gem_gtt.c
Indeed, makes sense. Dropped my original patch from dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-08-13 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 10:51 [PATCH 1/2] drm/i915: Flush the PTEs after updating them before suspend Chris Wilson
2014-08-13 10:51 ` [PATCH 2/2] drm/i915: Move i915_gem_chipset_flush to where it belongs Chris Wilson
2014-08-13 11:32 ` Daniel Vetter
2014-08-13 11:45 ` Chris Wilson
2014-08-13 12:23 ` Daniel Vetter [this message]
2014-08-13 11:32 ` [PATCH 1/2] drm/i915: Flush the PTEs after updating them before suspend Daniel Vetter
2014-08-13 11:46 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 10:44 [PATCH 1/2] drm/i915: Some cleanups for the ppgtt lifetime handling Daniel Vetter
2014-07-30 10:44 ` [PATCH 2/2] drm/i915: Move i915_gem_chipset_flush to where it belongs Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813122314.GY10500@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.