From: Stephen Boyd <sboyd@codeaurora.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler
Date: Wed, 13 Aug 2014 06:53:02 -0700 [thread overview]
Message-ID: <20140813135300.GC32301@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1408122205060.6061@knanqh.ubzr>
On 08/12, Nicolas Pitre wrote:
> On Tue, 12 Aug 2014, Stephen Boyd wrote:
> >
> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> > index 7c131cf7cc13..c1dc65209899 100644
> > --- a/drivers/irqchip/irq-gic.c
> > +++ b/drivers/irqchip/irq-gic.c
> > @@ -81,6 +81,11 @@ static DEFINE_RAW_SPINLOCK(irq_controller_lock);
> > #define NR_GIC_CPU_IF 8
> > static u8 gic_cpu_map[NR_GIC_CPU_IF] __read_mostly;
> >
> > +#ifdef CONFIG_BL_SWITCHER
> > +/* Synchronize switching CPU interface and sending SGIs */
> > +static DEFINE_RAW_SPINLOCK(gic_sgi_lock);
>
> What about ...
>
> #define sgi_map_lock(flags) raw_spin_lock_irqsave(&gic_sgi_lock, flags)
> #define sgi_map_unlock(flags) raw_spin_unlock_irqrestore(&gic_sgi_lock,
> flags)
> #else sgi_map_lock(flags) (void)(flags)
> #define sgi_map_unlock(flags) (void)(flags)
>
> That would avoid some #ifdefs in the main code.
Sure. v4 shortly.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler
Date: Wed, 13 Aug 2014 06:53:02 -0700 [thread overview]
Message-ID: <20140813135300.GC32301@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.11.1408122205060.6061@knanqh.ubzr>
On 08/12, Nicolas Pitre wrote:
> On Tue, 12 Aug 2014, Stephen Boyd wrote:
> >
> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> > index 7c131cf7cc13..c1dc65209899 100644
> > --- a/drivers/irqchip/irq-gic.c
> > +++ b/drivers/irqchip/irq-gic.c
> > @@ -81,6 +81,11 @@ static DEFINE_RAW_SPINLOCK(irq_controller_lock);
> > #define NR_GIC_CPU_IF 8
> > static u8 gic_cpu_map[NR_GIC_CPU_IF] __read_mostly;
> >
> > +#ifdef CONFIG_BL_SWITCHER
> > +/* Synchronize switching CPU interface and sending SGIs */
> > +static DEFINE_RAW_SPINLOCK(gic_sgi_lock);
>
> What about ...
>
> #define sgi_map_lock(flags) raw_spin_lock_irqsave(&gic_sgi_lock, flags)
> #define sgi_map_unlock(flags) raw_spin_unlock_irqrestore(&gic_sgi_lock,
> flags)
> #else sgi_map_lock(flags) (void)(flags)
> #define sgi_map_unlock(flags) (void)(flags)
>
> That would avoid some #ifdefs in the main code.
Sure. v4 shortly.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-08-13 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 0:54 [PATCH v3] irqchip: gic: Allow gic_arch_extn hooks to call into scheduler Stephen Boyd
2014-08-13 0:54 ` Stephen Boyd
2014-08-13 2:10 ` Nicolas Pitre
2014-08-13 2:10 ` Nicolas Pitre
2014-08-13 13:53 ` Stephen Boyd [this message]
2014-08-13 13:53 ` Stephen Boyd
2014-08-13 10:44 ` Daniel Thompson
2014-08-13 10:44 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813135300.GC32301@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.