All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 5/5] tty: serial: Add 8250-core based omap driver
Date: Wed, 13 Aug 2014 09:37:23 -0700	[thread overview]
Message-ID: <20140813163722.GA9239@atomide.com> (raw)
In-Reply-To: <53EB9066.3060208@linutronix.de>

* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [140813 09:23]:
> On 07/21/2014 11:35 AM, Tony Lindgren wrote:
> 
> > Looks like the following is needed to avoid the error, no idea why..
> > But this is what we also do in omap-serial.c. It may be needed in
> > other places too?
> 
> Yes, there was a third one on shutdown.

OK
 
> > Also, no luck yet on runtime PM. If the console is enabled omap won't
> > idle, and if no serial console is enabled, it just hangs. Will try
> > to debug this part further, it may be also related to the above.
> 
> My beaglebone xm won't do idle:
> 
> | omap3_pm_off_mode_enable: Core OFF disabled due to errata i583
> 
> but it would if it could, right? That means that I can't test the wake
> via UART on this one?

Hmm OK yes that's disabled for some earlier ES revisions. I guess you
could comment out the limitations for PM_SDRC_WAKEUP_ERRATUM_i583
in both cpuidle34xx.c and pm34xx.c and see if off-idle is usable for
your tests :) It might be flakey but still usable for testing.
 
> So I will try to fix the tx-pm, fold patches and then prepare another
> batch.

OK great, let me know if you need more help.

> And I could verify that DMA works on that omap3 :)

OK

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] tty: serial: Add 8250-core based omap driver
Date: Wed, 13 Aug 2014 09:37:23 -0700	[thread overview]
Message-ID: <20140813163722.GA9239@atomide.com> (raw)
In-Reply-To: <53EB9066.3060208@linutronix.de>

* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [140813 09:23]:
> On 07/21/2014 11:35 AM, Tony Lindgren wrote:
> 
> > Looks like the following is needed to avoid the error, no idea why..
> > But this is what we also do in omap-serial.c. It may be needed in
> > other places too?
> 
> Yes, there was a third one on shutdown.

OK
 
> > Also, no luck yet on runtime PM. If the console is enabled omap won't
> > idle, and if no serial console is enabled, it just hangs. Will try
> > to debug this part further, it may be also related to the above.
> 
> My beaglebone xm won't do idle:
> 
> | omap3_pm_off_mode_enable: Core OFF disabled due to errata i583
> 
> but it would if it could, right? That means that I can't test the wake
> via UART on this one?

Hmm OK yes that's disabled for some earlier ES revisions. I guess you
could comment out the limitations for PM_SDRC_WAKEUP_ERRATUM_i583
in both cpuidle34xx.c and pm34xx.c and see if off-idle is usable for
your tests :) It might be flakey but still usable for testing.
 
> So I will try to fix the tx-pm, fold patches and then prepare another
> batch.

OK great, let me know if you need more help.

> And I could verify that DMA works on that omap3 :)

OK

Regards,

Tony

  reply	other threads:[~2014-08-13 16:37 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 14:44 [PATCH v4] 8250-core based serial driver for OMAP Sebastian Andrzej Siewior
2014-07-16 14:44 ` Sebastian Andrzej Siewior
2014-07-16 14:44 ` Sebastian Andrzej Siewior
2014-07-16 14:44 ` [PATCH 1/5] tty: serial: 8250 core: provide a function to export uart_8250_port Sebastian Andrzej Siewior
2014-07-16 14:44   ` Sebastian Andrzej Siewior
2014-07-16 14:45 ` [PATCH 2/5] tty: serial: 8250 core: allow to overwrite & export serial8250_startup() Sebastian Andrzej Siewior
2014-07-16 14:45   ` Sebastian Andrzej Siewior
2014-07-16 14:45   ` Sebastian Andrzej Siewior
2014-07-16 14:45 ` [PATCH 3/5] tty: serial: 8250 core: allow to set ->throttle / ->unthrottle callbacks Sebastian Andrzej Siewior
2014-07-16 14:45   ` Sebastian Andrzej Siewior
2014-07-16 14:45 ` [PATCH 4/5] tty: serial: 8250 core: add runtime pm Sebastian Andrzej Siewior
2014-07-16 14:45   ` Sebastian Andrzej Siewior
2014-07-16 15:16   ` Felipe Balbi
2014-07-16 15:16     ` Felipe Balbi
2014-07-16 15:16     ` Felipe Balbi
2014-07-16 15:54     ` Sebastian Andrzej Siewior
2014-07-16 15:54       ` Sebastian Andrzej Siewior
2014-07-16 16:06       ` Felipe Balbi
2014-07-16 16:06         ` Felipe Balbi
2014-07-16 16:06         ` Felipe Balbi
2014-07-16 16:40         ` Sebastian Andrzej Siewior
2014-07-16 16:40           ` Sebastian Andrzej Siewior
2014-07-16 16:40           ` Sebastian Andrzej Siewior
2014-07-16 16:46           ` Felipe Balbi
2014-07-16 16:46             ` Felipe Balbi
2014-07-16 16:46             ` Felipe Balbi
2014-07-17 15:31         ` Peter Hurley
2014-07-17 15:31           ` Peter Hurley
2014-07-17 15:43           ` Sebastian Andrzej Siewior
2014-07-17 15:43             ` Sebastian Andrzej Siewior
2014-07-17 16:02             ` Felipe Balbi
2014-07-17 16:02               ` Felipe Balbi
2014-07-17 16:02               ` Felipe Balbi
2014-07-17 16:06               ` Sebastian Andrzej Siewior
2014-07-17 16:06                 ` Sebastian Andrzej Siewior
2014-07-17 16:18                 ` Felipe Balbi
2014-07-17 16:18                   ` Felipe Balbi
2014-07-17 16:18                   ` Felipe Balbi
2014-07-18  8:35                   ` Sebastian Andrzej Siewior
2014-07-18  8:35                     ` Sebastian Andrzej Siewior
2014-07-18  8:35                     ` Sebastian Andrzej Siewior
2014-07-18 15:31                     ` Felipe Balbi
2014-07-18 15:31                       ` Felipe Balbi
2014-07-18 15:31                       ` Felipe Balbi
2014-07-18 15:53                       ` Peter Hurley
2014-07-18 15:53                         ` Peter Hurley
2014-07-18 16:02                         ` Felipe Balbi
2014-07-18 16:02                           ` Felipe Balbi
2014-07-18 16:02                           ` Felipe Balbi
2014-07-16 14:45 ` [PATCH 5/5] tty: serial: Add 8250-core based omap driver Sebastian Andrzej Siewior
2014-07-16 14:45   ` Sebastian Andrzej Siewior
2014-07-17  7:09   ` Tony Lindgren
2014-07-17  7:09     ` Tony Lindgren
2014-07-17  7:09     ` Tony Lindgren
2014-07-17  7:42     ` Sebastian Andrzej Siewior
2014-07-17  7:42       ` Sebastian Andrzej Siewior
2014-07-17  8:12       ` Tony Lindgren
2014-07-17  8:12         ` Tony Lindgren
2014-07-17 10:06         ` Sebastian Andrzej Siewior
2014-07-17 10:06           ` Sebastian Andrzej Siewior
2014-07-18  6:24           ` Tony Lindgren
2014-07-18  6:24             ` Tony Lindgren
2014-07-18  6:24             ` Tony Lindgren
2014-07-21  9:35             ` Tony Lindgren
2014-07-21  9:35               ` Tony Lindgren
2014-07-21  9:35               ` Tony Lindgren
2014-08-13 16:20               ` Sebastian Andrzej Siewior
2014-08-13 16:20                 ` Sebastian Andrzej Siewior
2014-08-13 16:37                 ` Tony Lindgren [this message]
2014-08-13 16:37                   ` Tony Lindgren
2014-07-17 14:54   ` Felipe Balbi
2014-07-17 14:54     ` Felipe Balbi
2014-07-17 14:54     ` Felipe Balbi
2014-07-17 15:11     ` Sebastian Andrzej Siewior
2014-07-17 15:11       ` Sebastian Andrzej Siewior
2014-07-17 16:04       ` Felipe Balbi
2014-07-17 16:04         ` Felipe Balbi
2014-07-17 16:04         ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813163722.GA9239@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@ti.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.