All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Airlie <airlied@linux.ie>
Cc: kernel-janitors@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>,
	dri-devel@lists.freedesktop.org
Subject: [patch] drm/nouveau: indent an else statement
Date: Thu, 14 Aug 2014 08:03:18 +0000	[thread overview]
Message-ID: <20140814080318.GA4757@mwanda> (raw)

This else statement wasn't indented so it was confusing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_usif.c b/drivers/gpu/drm/nouveau/nouveau_usif.c
index cb1182d..41c9b404 100644
--- a/drivers/gpu/drm/nouveau/nouveau_usif.c
+++ b/drivers/gpu/drm/nouveau/nouveau_usif.c
@@ -83,9 +83,10 @@ usif_notify(const void *header, u32 length, const void *data, u32 size)
 		if (WARN_ON(!(ntfy = (void *)(unsigned long)rep->v0.token)))
 			return NVIF_NOTIFY_DROP;
 		BUG_ON(rep->v0.route != NVDRM_NOTIFY_USIF);
-	} else
-	if (WARN_ON(1))
-		return NVIF_NOTIFY_DROP;
+	} else {
+		if (WARN_ON(1))
+			return NVIF_NOTIFY_DROP;
+	}
 
 	if (WARN_ON(!ntfy->p || ntfy->reply != (length + size)))
 		return NVIF_NOTIFY_DROP;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Airlie <airlied@linux.ie>
Cc: kernel-janitors@vger.kernel.org, Ben Skeggs <bskeggs@redhat.com>,
	dri-devel@lists.freedesktop.org
Subject: [patch] drm/nouveau: indent an else statement
Date: Thu, 14 Aug 2014 11:03:18 +0300	[thread overview]
Message-ID: <20140814080318.GA4757@mwanda> (raw)

This else statement wasn't indented so it was confusing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_usif.c b/drivers/gpu/drm/nouveau/nouveau_usif.c
index cb1182d..41c9b404 100644
--- a/drivers/gpu/drm/nouveau/nouveau_usif.c
+++ b/drivers/gpu/drm/nouveau/nouveau_usif.c
@@ -83,9 +83,10 @@ usif_notify(const void *header, u32 length, const void *data, u32 size)
 		if (WARN_ON(!(ntfy = (void *)(unsigned long)rep->v0.token)))
 			return NVIF_NOTIFY_DROP;
 		BUG_ON(rep->v0.route != NVDRM_NOTIFY_USIF);
-	} else
-	if (WARN_ON(1))
-		return NVIF_NOTIFY_DROP;
+	} else {
+		if (WARN_ON(1))
+			return NVIF_NOTIFY_DROP;
+	}
 
 	if (WARN_ON(!ntfy->p || ntfy->reply != (length + size)))
 		return NVIF_NOTIFY_DROP;

             reply	other threads:[~2014-08-14  8:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  8:03 Dan Carpenter [this message]
2014-08-14  8:03 ` [patch] drm/nouveau: indent an else statement Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140814080318.GA4757@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.