[PATCH 0/2] MIPS: add common plat_irq_dispatch declaration

[PATCH 0/2] MIPS: add common plat_irq_dispatch declaration

[Sergey Ryazanov]

This short series get rid of one nasty sparse warning "symbol
'plat_irq_dispatch' was not declared. Should it be static?"

Compile tested with following configs:
  ar7_defconfig
  ath79_defconfig
  bcm47xx_defconfig
  bcm63xx_defconfig
  bigsur_defconfig
  capcella_defconfig
  cavium_octeon_defconfig
  cobalt_defconfig
  db1xxx_defconfig
  decstation_defconfig
  e55_defconfig
  fuloong2e_defconfig
  gpr_defconfig
  ip22_defconfig
  ip27_defconfig
  ip32_defconfig
  jazz_defconfig
  jmr3927_defconfig
  lasat_defconfig
  lemote2f_defconfig
  loongson3_defconfig
  ls1b_defconfig
  maltaaprp_defconfig
  malta_defconfig
  malta_kvm_defconfig
  malta_kvm_guest_defconfig
  maltasmvp_defconfig
  maltaup_defconfig
  markeins_defconfig
  mips_paravirt_defconfig
  mpc30x_defconfig
  msp71xx_defconfig
  mtx1_defconfig
  pnx8335_stb225_defconfig
  qi_lb60_defconfig
  rb532_defconfig
  rbtx49xx_defconfig
  rm200_defconfig
  rt305x_defconfig
  sb1250_swarm_defconfig
  sead3_defconfig
  sead3micro_defconfig
  tb0219_defconfig
  tb0226_defconfig
  tb0287_defconfig
  workpad_defconfig
  xway_defconfig

Could not test following configs since compiller lacks and some macro redefinitions:
  ip28_defconfig
  maltasmvp_eva_defconfig
  nlm_xlp_defconfig
  nlm_xlr_defconfig

Sergey Ryazanov (2):
  MIPS: MSP71xx: remove unused plat_irq_dispatch() argument
  MIPS: add common plat_irq_dispatch declaration

 arch/mips/cavium-octeon/setup.c  | 1 -
 arch/mips/include/asm/irq.h      | 2 ++
 arch/mips/pmcs-msp71xx/msp_irq.c | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

-- 
1.8.1.5

[PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument

[Sergey Ryazanov]

Remove unused argument to make the plat_irq_dispatch() function
declaration similar to the realization of other platforms.

Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
---
 arch/mips/pmcs-msp71xx/msp_irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pmcs-msp71xx/msp_irq.c b/arch/mips/pmcs-msp71xx/msp_irq.c
index 941744a..f914c75 100644
--- a/arch/mips/pmcs-msp71xx/msp_irq.c
+++ b/arch/mips/pmcs-msp71xx/msp_irq.c
@@ -51,7 +51,7 @@ static inline void sec_int_dispatch(void)  { do_IRQ(MSP_INT_SEC);  }
  * the range 40-71.
  */
 
-asmlinkage void plat_irq_dispatch(struct pt_regs *regs)
+asmlinkage void plat_irq_dispatch(void)
 {
 	u32 pending;
 
-- 
1.8.1.5

Re: [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument

[Ralf Baechle]

On Thu, Aug 14, 2014 at 02:09:35AM +0400, Sergey Ryazanov wrote:

> Remove unused argument to make the plat_irq_dispatch() function
> declaration similar to the realization of other platforms.

The issue may be harmless but the regs argument of the false argument
isn't even being passed in!

  Ralf

Re: [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument

[Sergey Ryazanov]

2014-08-14 16:46 GMT+04:00 Ralf Baechle <ralf@linux-mips.org>:
> On Thu, Aug 14, 2014 at 02:09:35AM +0400, Sergey Ryazanov wrote:
>
>> Remove unused argument to make the plat_irq_dispatch() function
>> declaration similar to the realization of other platforms.
>
> The issue may be harmless but the regs argument of the false argument
> isn't even being passed in!
>
IMHO, this argument can't cause smth terrible, until nobody tries to
access it, but I can mistake.

-- 
Sergey

Re: [PATCH 1/2] MIPS: MSP71xx: remove unused plat_irq_dispatch() argument

[Ralf Baechle]

On Thu, Aug 14, 2014 at 06:39:17PM +0400, Sergey Ryazanov wrote:

> >> Remove unused argument to make the plat_irq_dispatch() function
> >> declaration similar to the realization of other platforms.
> >
> > The issue may be harmless but the regs argument of the false argument
> > isn't even being passed in!
> >
> IMHO, this argument can't cause smth terrible, until nobody tries to
> access it, but I can mistake.

Correct.

In this particular case it appears that the value passed for regs is
whatever value there was in $a0 in the interrupted code.  Dereferencing
that kind of value would most likely be lethal and crash the kernel
during bootup.

  Ralf

[PATCH 2/2] MIPS: add common plat_irq_dispatch declaration

[Sergey Ryazanov]

Add common declaration to get rid of following sparse warning: "symbol
'plat_irq_dispatch' was not declared. Should it be static?"

Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
---
 arch/mips/cavium-octeon/setup.c | 1 -
 arch/mips/include/asm/irq.h     | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
index 008e9c8..dba7cf7 100644
--- a/arch/mips/cavium-octeon/setup.c
+++ b/arch/mips/cavium-octeon/setup.c
@@ -263,7 +263,6 @@ static uint64_t crashk_size, crashk_base;
 static int octeon_uart;
 
 extern asmlinkage void handle_int(void);
-extern asmlinkage void plat_irq_dispatch(void);
 
 /**
  * Return non zero if we are currently running in the Octeon simulator
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
index ae1f7b2..39f07ae 100644
--- a/arch/mips/include/asm/irq.h
+++ b/arch/mips/include/asm/irq.h
@@ -26,6 +26,8 @@ static inline int irq_canonicalize(int irq)
 #define irq_canonicalize(irq) (irq)	/* Sane hardware, sane code ... */
 #endif
 
+asmlinkage void plat_irq_dispatch(void);
+
 extern void do_IRQ(unsigned int irq);
 
 extern void arch_init_irq(void);
-- 
1.8.1.5