All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Kevin Hilman <khilman@linaro.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_in
Date: Thu, 14 Aug 2014 21:18:17 +0000	[thread overview]
Message-ID: <20140814211817.GD2029@verge.net.au> (raw)
In-Reply-To: <53ECEB7E.9040300@gmail.com>

On Thu, Aug 14, 2014 at 10:01:50AM -0700, Florian Fainelli wrote:
> Hi Geert,
> 
> On 08/14/2014 01:52 AM, Geert Uytterhoeven wrote:
> > Hi Simon,
> > 
> > (taking this to netdev for the crash in smsc911x_suspend())
> > 
> > On Thu, Aug 14, 2014 at 8:16 AM, Simon Horman <horms@verge.net.au> wrote:
> >> while this may be part of the puzzle my light testing shows
> >> that suspend-to-ram does not appear to work with this patch applied.
> > 
> > Thanks for testing!
> 
> Sounds like you are another victim of:
> a71e3c37960ce5f9 ("net: phy: Set the driver when registering an MDIO bus
> device")
> 
> which got reverted just recently:
> ce7991e8198b80eb6b4441b6f6114bea4a665d66 ("Revert "net: phy: Set the
> driver when registering an MDIO bus device"").

Thanks, that did the trick.

Geert, I'll queue up your patch for the r8a7778.

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Kevin Hilman <khilman@linaro.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late())
Date: Fri, 15 Aug 2014 06:18:17 +0900	[thread overview]
Message-ID: <20140814211817.GD2029@verge.net.au> (raw)
In-Reply-To: <53ECEB7E.9040300@gmail.com>

On Thu, Aug 14, 2014 at 10:01:50AM -0700, Florian Fainelli wrote:
> Hi Geert,
> 
> On 08/14/2014 01:52 AM, Geert Uytterhoeven wrote:
> > Hi Simon,
> > 
> > (taking this to netdev for the crash in smsc911x_suspend())
> > 
> > On Thu, Aug 14, 2014 at 8:16 AM, Simon Horman <horms@verge.net.au> wrote:
> >> while this may be part of the puzzle my light testing shows
> >> that suspend-to-ram does not appear to work with this patch applied.
> > 
> > Thanks for testing!
> 
> Sounds like you are another victim of:
> a71e3c37960ce5f9 ("net: phy: Set the driver when registering an MDIO bus
> device")
> 
> which got reverted just recently:
> ce7991e8198b80eb6b4441b6f6114bea4a665d66 ("Revert "net: phy: Set the
> driver when registering an MDIO bus device"").

Thanks, that did the trick.

Geert, I'll queue up your patch for the r8a7778.

  reply	other threads:[~2014-08-14 21:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14  8:52 smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_l Geert Uytterhoeven
2014-08-14  8:52 ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late()) Geert Uytterhoeven
2014-08-14 17:01 ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_in Florian Fainelli
2014-08-14 17:01   ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late()) Florian Fainelli
2014-08-14 21:18   ` Simon Horman [this message]
2014-08-14 21:18     ` Simon Horman
2014-08-15  8:33     ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_in Geert Uytterhoeven
2014-08-15  8:33       ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late()) Geert Uytterhoeven
2014-08-14 21:17 ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_in Simon Horman
2014-08-14 21:17   ` smsc911x_suspend crash (was: Re: [PATCH] ARM: shmobile: r8a7778: Add missing call to shmobile_init_late()) Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140814211817.GD2029@verge.net.au \
    --to=horms@verge.net.au \
    --cc=f.fainelli@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=khilman@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.