From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: smp: Update the topology masks before calling CPU_STARTING notifiers
Date: Fri, 15 Aug 2014 11:43:34 +0100 [thread overview]
Message-ID: <20140815104333.GH27466@arm.com> (raw)
In-Reply-To: <1407892269-28650-1-git-send-email-rvaswani@codeaurora.org>
On Wed, Aug 13, 2014 at 02:11:09AM +0100, Rohit Vaswani wrote:
> Currently, the CPU_STARTING notifiers would observe an incorrect sibling
> mask since the notifier chain is called before the topology masks are updated
> for the new cpu.
> Update the topology masks before calling the notifier chain to fix this
> problem.
>
> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
> ---
> arch/arm/kernel/smp.c | 4 ++--
> arch/arm64/kernel/smp.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index 7c4fada..0e2237c 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -363,12 +363,12 @@ asmlinkage void secondary_start_kernel(void)
> if (smp_ops.smp_secondary_init)
> smp_ops.smp_secondary_init(cpu);
>
> + smp_store_cpu_info(cpu);
> +
> notify_cpu_starting(cpu);
>
> calibrate_delay();
>
> - smp_store_cpu_info(cpu);
> -
Hmm, smp_store_cpu_info takes a copy of loops_per_jiffy. Are you sure it's
safe to move the call before calibrate_delay?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Rohit Vaswani <rvaswani@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: smp: Update the topology masks before calling CPU_STARTING notifiers
Date: Fri, 15 Aug 2014 11:43:34 +0100 [thread overview]
Message-ID: <20140815104333.GH27466@arm.com> (raw)
In-Reply-To: <1407892269-28650-1-git-send-email-rvaswani@codeaurora.org>
On Wed, Aug 13, 2014 at 02:11:09AM +0100, Rohit Vaswani wrote:
> Currently, the CPU_STARTING notifiers would observe an incorrect sibling
> mask since the notifier chain is called before the topology masks are updated
> for the new cpu.
> Update the topology masks before calling the notifier chain to fix this
> problem.
>
> Signed-off-by: Rohit Vaswani <rvaswani@codeaurora.org>
> ---
> arch/arm/kernel/smp.c | 4 ++--
> arch/arm64/kernel/smp.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> index 7c4fada..0e2237c 100644
> --- a/arch/arm/kernel/smp.c
> +++ b/arch/arm/kernel/smp.c
> @@ -363,12 +363,12 @@ asmlinkage void secondary_start_kernel(void)
> if (smp_ops.smp_secondary_init)
> smp_ops.smp_secondary_init(cpu);
>
> + smp_store_cpu_info(cpu);
> +
> notify_cpu_starting(cpu);
>
> calibrate_delay();
>
> - smp_store_cpu_info(cpu);
> -
Hmm, smp_store_cpu_info takes a copy of loops_per_jiffy. Are you sure it's
safe to move the call before calibrate_delay?
Will
next prev parent reply other threads:[~2014-08-15 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 1:11 [PATCH] arm64: smp: Update the topology masks before calling CPU_STARTING notifiers Rohit Vaswani
2014-08-13 1:11 ` Rohit Vaswani
2014-08-15 10:43 ` Will Deacon [this message]
2014-08-15 10:43 ` Will Deacon
2014-08-15 23:12 ` Rohit Vaswani
2014-08-15 23:12 ` Rohit Vaswani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815104333.GH27466@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.