From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2] I2C: Rework kernel config I2C_ACPI
Date: Fri, 15 Aug 2014 06:03:23 -0500 [thread overview]
Message-ID: <20140815110323.GA2860@katana> (raw)
In-Reply-To: <1408081139-6292-1-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Fri, Aug 15, 2014 at 01:38:59PM +0800, Lan Tianyu wrote:
> Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI
> config) adds a new kernel config I2C_ACPI and make I2C core built in
> when the config is selected. This is wrong because distributions
> etc generally compile I2C as a module and the commit broken that.
> This patch is to rename I2C_ACPI to ACPI_I2C_OPREGION. New config
> only controls ACPI I2C operation region code and depends on I2C=y.
>
> Signed-off-by: Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
It looks good. What tests did you perform?
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: mika.westerberg@linux.intel.com, torvalds@linux-foundation.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] I2C: Rework kernel config I2C_ACPI
Date: Fri, 15 Aug 2014 06:03:23 -0500 [thread overview]
Message-ID: <20140815110323.GA2860@katana> (raw)
In-Reply-To: <1408081139-6292-1-git-send-email-tianyu.lan@intel.com>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Fri, Aug 15, 2014 at 01:38:59PM +0800, Lan Tianyu wrote:
> Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI
> config) adds a new kernel config I2C_ACPI and make I2C core built in
> when the config is selected. This is wrong because distributions
> etc generally compile I2C as a module and the commit broken that.
> This patch is to rename I2C_ACPI to ACPI_I2C_OPREGION. New config
> only controls ACPI I2C operation region code and depends on I2C=y.
>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
It looks good. What tests did you perform?
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-15 11:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 7:00 [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected Lan Tianyu
2014-08-11 7:00 ` Lan Tianyu
[not found] ` <1407740455-21269-1-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-12 9:53 ` Mika Westerberg
2014-08-12 9:53 ` Mika Westerberg
[not found] ` <20140812095321.GU1657-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-08-13 2:03 ` Wolfram Sang
2014-08-13 2:03 ` Wolfram Sang
2014-08-13 2:50 ` Lan Tianyu
2014-08-13 2:50 ` Lan Tianyu
[not found] ` <53EAD278.2010003-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-13 7:07 ` Mika Westerberg
2014-08-13 7:07 ` Mika Westerberg
[not found] ` <20140813070759.GB1657-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-08-13 7:22 ` Lan Tianyu
2014-08-13 7:22 ` Lan Tianyu
2014-08-14 9:37 ` Wolfram Sang
2014-08-15 5:38 ` [PATCH V2] I2C: Rework kernel config I2C_ACPI Lan Tianyu
2014-08-15 5:38 ` Lan Tianyu
[not found] ` <1408081139-6292-1-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-15 8:25 ` Mika Westerberg
2014-08-15 8:25 ` Mika Westerberg
2014-08-15 11:03 ` Wolfram Sang [this message]
2014-08-15 11:03 ` Wolfram Sang
2014-08-18 1:59 ` Lan Tianyu
2014-08-18 1:59 ` Lan Tianyu
2014-08-19 14:44 ` Wolfram Sang
2014-08-19 14:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815110323.GA2860@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.