* [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
@ 2014-08-18 11:00 ` Inha Song
0 siblings, 0 replies; 8+ messages in thread
From: Inha Song @ 2014-08-18 11:00 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, patches, linux-kernel, lee.jones, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
Some boards need to set the INn_MODE[1:0] register to change
the input signal patch. This wlf,inmode property is optional.
If present, values must be specified less than or equal to
the number of input singals. If values less than the number
of input signals, elements that has not been specifed are set
to 0 by default.
Example:
- wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
Signed-off-by: Inha Song <ideal.song@samsung.com>
---
drivers/mfd/arizona-core.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 10a0cb9..81e6db8 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
static int arizona_of_get_core_pdata(struct arizona *arizona)
{
struct arizona_pdata *pdata = &arizona->pdata;
- int ret, i;
+ int ret, i, proplen;
pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
@@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
ret);
}
+ proplen = of_property_count_u32_elems(arizona->dev->of_node,
+ "wlf,inmode");
+ if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
+ of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
+ arizona->pdata.inmode, proplen);
+
return 0;
}
--
2.0.0.390.gcb682f8
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
2014-08-18 11:00 ` [alsa-devel] " Inha Song
(?)
@ 2014-08-18 14:23 ` Charles Keepax
-1 siblings, 0 replies; 8+ messages in thread
From: Charles Keepax @ 2014-08-18 14:23 UTC (permalink / raw)
To: Inha Song
Cc: broonie, alsa-devel, patches, linux-kernel, lee.jones, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
On Mon, Aug 18, 2014 at 08:00:03PM +0900, Inha Song wrote:
> Some boards need to set the INn_MODE[1:0] register to change
> the input signal patch. This wlf,inmode property is optional.
> If present, values must be specified less than or equal to
> the number of input singals. If values less than the number
> of input signals, elements that has not been specifed are set
> to 0 by default.
>
> Example:
> - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
2014-08-18 11:00 ` [alsa-devel] " Inha Song
@ 2014-08-28 11:36 ` Lee Jones
-1 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2014-08-28 11:36 UTC (permalink / raw)
To: Inha Song
Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, sameo-VuQAYsv1563Yd54FQh9/CA,
devicetree-u79uwXL29TY76Z2rM5mHXA, galak-sgV2jX0FEOL9JmXXK+q4OQ,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, mark.rutland-5wv7dgnIgG8,
pawel.moll-5wv7dgnIgG8, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
cw00.choi-Sze3O3UU22JBDgjK7y7TUQ
On Mon, 18 Aug 2014, Inha Song wrote:
> Some boards need to set the INn_MODE[1:0] register to change
> the input signal patch. This wlf,inmode property is optional.
> If present, values must be specified less than or equal to
> the number of input singals. If values less than the number
> of input signals, elements that has not been specifed are set
> to 0 by default.
>
> Example:
> - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
>
> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/mfd/arizona-core.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 10a0cb9..81e6db8 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> static int arizona_of_get_core_pdata(struct arizona *arizona)
> {
> struct arizona_pdata *pdata = &arizona->pdata;
> - int ret, i;
> + int ret, i, proplen;
>
> pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
>
> @@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> ret);
> }
>
> + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> + "wlf,inmode");
> + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
> + of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
> + arizona->pdata.inmode, proplen);
of_property_for_each_u32()?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
@ 2014-08-28 11:36 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2014-08-28 11:36 UTC (permalink / raw)
To: Inha Song
Cc: broonie, alsa-devel, patches, linux-kernel, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
On Mon, 18 Aug 2014, Inha Song wrote:
> Some boards need to set the INn_MODE[1:0] register to change
> the input signal patch. This wlf,inmode property is optional.
> If present, values must be specified less than or equal to
> the number of input singals. If values less than the number
> of input signals, elements that has not been specifed are set
> to 0 by default.
>
> Example:
> - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
> drivers/mfd/arizona-core.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 10a0cb9..81e6db8 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> static int arizona_of_get_core_pdata(struct arizona *arizona)
> {
> struct arizona_pdata *pdata = &arizona->pdata;
> - int ret, i;
> + int ret, i, proplen;
>
> pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
>
> @@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> ret);
> }
>
> + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> + "wlf,inmode");
> + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
> + of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
> + arizona->pdata.inmode, proplen);
of_property_for_each_u32()?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
2014-08-28 11:36 ` Lee Jones
(?)
@ 2014-08-29 8:02 ` Inha Song
2014-08-29 8:17 ` Lee Jones
-1 siblings, 1 reply; 8+ messages in thread
From: Inha Song @ 2014-08-29 8:02 UTC (permalink / raw)
To: Lee Jones
Cc: broonie, alsa-devel, patches, linux-kernel, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
Hi, Lee
Thanks for your review.
On Thu, 28 Aug 2014 12:36:51 +0100
Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 18 Aug 2014, Inha Song wrote:
>
> > Some boards need to set the INn_MODE[1:0] register to change
> > the input signal patch. This wlf,inmode property is optional.
> > If present, values must be specified less than or equal to
> > the number of input singals. If values less than the number
> > of input signals, elements that has not been specifed are set
> > to 0 by default.
> >
> > Example:
> > - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
> >
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> > drivers/mfd/arizona-core.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > index 10a0cb9..81e6db8 100644
> > --- a/drivers/mfd/arizona-core.c
> > +++ b/drivers/mfd/arizona-core.c
> > @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> > static int arizona_of_get_core_pdata(struct arizona *arizona)
> > {
> > struct arizona_pdata *pdata = &arizona->pdata;
> > - int ret, i;
> > + int ret, i, proplen;
> >
> > pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
> >
> > @@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> > ret);
> > }
> >
> > + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> > + "wlf,inmode");
> > + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
> > + of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
> > + arizona->pdata.inmode, proplen);
>
> of_property_for_each_u32()?
Is it more clear to use of_property_for_each_u32() instead of
of_property_read_u32_array()?
If so, I will fix in v5.
Best regards,
Inha Song.
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
2014-08-29 8:02 ` Inha Song
@ 2014-08-29 8:17 ` Lee Jones
2014-08-29 8:42 ` Inha Song
0 siblings, 1 reply; 8+ messages in thread
From: Lee Jones @ 2014-08-29 8:17 UTC (permalink / raw)
To: Inha Song
Cc: broonie, alsa-devel, patches, linux-kernel, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
On Fri, 29 Aug 2014, Inha Song wrote:
> Hi, Lee
> Thanks for your review.
>
> On Thu, 28 Aug 2014 12:36:51 +0100
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > On Mon, 18 Aug 2014, Inha Song wrote:
> >
> > > Some boards need to set the INn_MODE[1:0] register to change
> > > the input signal patch. This wlf,inmode property is optional.
> > > If present, values must be specified less than or equal to
> > > the number of input singals. If values less than the number
> > > of input signals, elements that has not been specifed are set
> > > to 0 by default.
> > >
> > > Example:
> > > - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
> > >
> > > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > > ---
> > > drivers/mfd/arizona-core.c | 8 +++++++-
> > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > > index 10a0cb9..81e6db8 100644
> > > --- a/drivers/mfd/arizona-core.c
> > > +++ b/drivers/mfd/arizona-core.c
> > > @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> > > static int arizona_of_get_core_pdata(struct arizona *arizona)
> > > {
> > > struct arizona_pdata *pdata = &arizona->pdata;
> > > - int ret, i;
> > > + int ret, i, proplen;
> > >
> > > pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
> > >
> > > @@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> > > ret);
> > > }
> > >
> > > + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> > > + "wlf,inmode");
> > > + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
> > > + of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
> > > + arizona->pdata.inmode, proplen);
> >
> > of_property_for_each_u32()?
>
> Is it more clear to use of_property_for_each_u32() instead of
> of_property_read_u32_array()?
It prevents you from having to use of_property_count_u32_elems() first.
> If so, I will fix in v5.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [alsa-devel] [PATCH v3 1/2] mfd: arizona: Add support for INn_Modec register control
2014-08-29 8:17 ` Lee Jones
@ 2014-08-29 8:42 ` Inha Song
0 siblings, 0 replies; 8+ messages in thread
From: Inha Song @ 2014-08-29 8:42 UTC (permalink / raw)
To: Lee Jones
Cc: broonie, alsa-devel, patches, linux-kernel, ckeepax, lgirdwood,
sameo, devicetree, galak, ijc+devicetree, mark.rutland,
pawel.moll, robh+dt, cw00.choi
On Fri, 29 Aug 2014 09:17:41 +0100
Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 29 Aug 2014, Inha Song wrote:
>
> > Hi, Lee
> > Thanks for your review.
> >
> > On Thu, 28 Aug 2014 12:36:51 +0100
> > Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > On Mon, 18 Aug 2014, Inha Song wrote:
> > >
> > > > Some boards need to set the INn_MODE[1:0] register to change
> > > > the input signal patch. This wlf,inmode property is optional.
> > > > If present, values must be specified less than or equal to
> > > > the number of input singals. If values less than the number
> > > > of input signals, elements that has not been specifed are set
> > > > to 0 by default.
> > > >
> > > > Example:
> > > > - wlf,inmode = <2 0 2>; /* IN1, IN3 use DMIC */
> > > >
> > > > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > > > ---
> > > > drivers/mfd/arizona-core.c | 8 +++++++-
> > > > 1 file changed, 7 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> > > > index 10a0cb9..81e6db8 100644
> > > > --- a/drivers/mfd/arizona-core.c
> > > > +++ b/drivers/mfd/arizona-core.c
> > > > @@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(arizona_of_get_named_gpio);
> > > > static int arizona_of_get_core_pdata(struct arizona *arizona)
> > > > {
> > > > struct arizona_pdata *pdata = &arizona->pdata;
> > > > - int ret, i;
> > > > + int ret, i, proplen;
> > > >
> > > > pdata->reset = arizona_of_get_named_gpio(arizona, "wlf,reset", true);
> > > >
> > > > @@ -560,6 +560,12 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
> > > > ret);
> > > > }
> > > >
> > > > + proplen = of_property_count_u32_elems(arizona->dev->of_node,
> > > > + "wlf,inmode");
> > > > + if (proplen > 0 && proplen <= ARRAY_SIZE(arizona->pdata.inmode))
> > > > + of_property_read_u32_array(arizona->dev->of_node, "wlf,inmode",
> > > > + arizona->pdata.inmode, proplen);
> > >
> > > of_property_for_each_u32()?
> >
> > Is it more clear to use of_property_for_each_u32() instead of
> > of_property_read_u32_array()?
>
> It prevents you from having to use of_property_count_u32_elems() first.
OK, I will fix this. Thanks.
Best regards,
Inha Song.
^ permalink raw reply [flat|nested] 8+ messages in thread