From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/12] ARM: dts: sun8i: Add i2c controller nodes
Date: Mon, 18 Aug 2014 16:27:37 +0200 [thread overview]
Message-ID: <20140818142737.GC15297@lukather> (raw)
In-Reply-To: <CAGb2v67NwsJORoFrgEECDtexXGtF5qOx7NX1PVpZHkjVs-mG2A@mail.gmail.com>
On Sun, Aug 17, 2014 at 11:20:44PM +0800, Chen-Yu Tsai wrote:
> Hi,
>
> On Sun, Aug 17, 2014 at 4:02 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Sun, Aug 17, 2014 at 11:52:17AM +0800, Chen-Yu Tsai wrote:
> >> Add nodes for the 3 i2c controllers found on A23 SoCs to the sun8i DTSI.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> arch/arm/boot/dts/sun8i-a23.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 36 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun8i-a23.dtsi b/arch/arm/boot/dts/sun8i-a23.dtsi
> >> index 4658998..53ef350 100644
> >> --- a/arch/arm/boot/dts/sun8i-a23.dtsi
> >> +++ b/arch/arm/boot/dts/sun8i-a23.dtsi
> >> @@ -387,6 +387,42 @@
> >> status = "disabled";
> >> };
> >>
> >> + i2c0: i2c at 01c2ac00 {
> >> + compatible = "allwinner,sun6i-a31-i2c";
> >> + reg = <0x01c2ac00 0x400>;
> >> + interrupts = <0 6 4>;
> >> + clocks = <&apb2_gates 0>;
> >> + clock-frequency = <100000>;
> >
> > It's the default, you don't need to set it.
>
> Ah, just checked the driver, it is indeed the default.
> All the other sunxi dtsi have it though. Do we want to be consistent?
Yep, it's usually a good thing :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140818/66fc8503/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-sunxi <linux-sunxi@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/12] ARM: dts: sun8i: Add i2c controller nodes
Date: Mon, 18 Aug 2014 16:27:37 +0200 [thread overview]
Message-ID: <20140818142737.GC15297@lukather> (raw)
In-Reply-To: <CAGb2v67NwsJORoFrgEECDtexXGtF5qOx7NX1PVpZHkjVs-mG2A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]
On Sun, Aug 17, 2014 at 11:20:44PM +0800, Chen-Yu Tsai wrote:
> Hi,
>
> On Sun, Aug 17, 2014 at 4:02 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi,
> >
> > On Sun, Aug 17, 2014 at 11:52:17AM +0800, Chen-Yu Tsai wrote:
> >> Add nodes for the 3 i2c controllers found on A23 SoCs to the sun8i DTSI.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> ---
> >> arch/arm/boot/dts/sun8i-a23.dtsi | 36 ++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 36 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun8i-a23.dtsi b/arch/arm/boot/dts/sun8i-a23.dtsi
> >> index 4658998..53ef350 100644
> >> --- a/arch/arm/boot/dts/sun8i-a23.dtsi
> >> +++ b/arch/arm/boot/dts/sun8i-a23.dtsi
> >> @@ -387,6 +387,42 @@
> >> status = "disabled";
> >> };
> >>
> >> + i2c0: i2c@01c2ac00 {
> >> + compatible = "allwinner,sun6i-a31-i2c";
> >> + reg = <0x01c2ac00 0x400>;
> >> + interrupts = <0 6 4>;
> >> + clocks = <&apb2_gates 0>;
> >> + clock-frequency = <100000>;
> >
> > It's the default, you don't need to set it.
>
> Ah, just checked the driver, it is indeed the default.
> All the other sunxi dtsi have it though. Do we want to be consistent?
Yep, it's usually a good thing :)
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-18 14:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-17 3:52 [PATCH 00/12] ARM: sun8i: Enable pinctrl, i2c and mmc Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 01/12] ARM: dts: sun8i: Add PIO controller node to the sun8i dtsi Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 02/12] ARM: dts: sun8i: Add R_PIO controller node to the dtsi Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 03/12] ARM: dts: sun8i: Add pinmux set for uart0 Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 04/12] ARM: dts: sun8i: Add pin muxing option for R_UART Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 05/12] ARM: dts: sun8i: ippo-q8h: Add pinctrl properties " Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 06/12] ARM: dts: sun8i: Add mmc clocks to the dtsi Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 07/12] ARM: dts: sun8i: Add pin-muxing info for the mmc controllers Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 08/12] ARM: dts: sun8i: Add mmc controller nodes Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 09/12] ARM: dts: sun8i: Enable mmc controller on ippo-q8h-v5 Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 10/12] ARM: dts: sun8i: Add pin-muxing info for the i2c controllers Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 11/12] ARM: dts: sun8i: Add i2c controller nodes Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 8:02 ` Maxime Ripard
2014-08-17 8:02 ` Maxime Ripard
2014-08-17 15:20 ` Chen-Yu Tsai
2014-08-17 15:20 ` Chen-Yu Tsai
2014-08-18 14:27 ` Maxime Ripard [this message]
2014-08-18 14:27 ` Maxime Ripard
2014-08-18 15:57 ` [linux-sunxi] " Chen-Yu Tsai
2014-08-18 15:57 ` Chen-Yu Tsai
2014-08-17 3:52 ` [PATCH 12/12] ARM: dts: sun8i: Enable i2c controllers on ippo-q8h-v5 Chen-Yu Tsai
2014-08-17 3:52 ` Chen-Yu Tsai
2014-08-17 8:03 ` [PATCH 00/12] ARM: sun8i: Enable pinctrl, i2c and mmc Maxime Ripard
2014-08-17 8:03 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818142737.GC15297@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.