All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Barker <paul@paulbarker.me.uk>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembeded-devel <Openembedded-devel@lists.openembedded.org>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: Announcing meta-musl OE/Yocto layer supporting musl C library
Date: Mon, 18 Aug 2014 19:54:08 +0000	[thread overview]
Message-ID: <20140818195408.GD7174@gmail.com> (raw)
In-Reply-To: <20140818193102.GC7174@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

On Mon, Aug 18, 2014 at 07:31:02PM +0000, Paul Barker wrote:
> On Mon, Aug 18, 2014 at 12:14:08PM -0700, Khem Raj wrote:
> > On Mon, Aug 18, 2014 at 12:08 PM, Paul Barker <paul@paulbarker.me.uk> wrote:
> > >> That would be handy too. But I wanted was to keep this info in project
> > >> for folks to try it out.
> > >>
> > >
> > > I'll just post one ticket for now.
> > >
> > 
> > Thats fine too.
> > 
> > > I think I've got a fix for e2fsprogs as well.
> > 
> > Great. when we write patches that arise out of musl systems we should
> > make sure that
> > 
> > 1. If patch fixes a genuine issue surfaced with musl, fight it out ar
> > respective package upstream and in OE universe add it to the original
> > layer where recipe primarily resides
> > but we can keep the patches in meta-musl as a last resort.
> > 
> > 2. If its something musl specific then lets keep it in meta-musl and
> > see how musl can be changed to fix it.
> > 
> > Thanks
> > -Khem
> 
> That makes sense. I'd suggest adding that to the README file in meta-musl so
> other would-be-contributors notice it.
> 
> In this case, it's ensuring that 'uint64_t' is used instead of '__uint64_t' and
> that <limits.h> is included where needed for 'PATH_MAX'. So I'd say those fixes
> belong in oe-core and are candidates for submitting upstream.
> 

Actually, both of these are fixed upstream already, but not as isolated commits
I can backport. There is a newer upstream release (v1.42.11) but it doesn't
contain the necessary fixes. It appears that the missing <limits.h> inclusion is
in a file added by patches in openembedded-core.

I shan't attempt the upgrade as there are a lot of patches in openembedded-core
to consider. I will try to make an isolated fix for the build issues with musl
though.

Cheers,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

[-- Attachment #2: Type: application/pgp-signature, Size: 484 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Paul Barker <paul@paulbarker.me.uk>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembeded-devel <Openembedded-devel@lists.openembedded.org>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] Announcing meta-musl OE/Yocto layer supporting musl C library
Date: Mon, 18 Aug 2014 19:54:08 +0000	[thread overview]
Message-ID: <20140818195408.GD7174@gmail.com> (raw)
In-Reply-To: <20140818193102.GC7174@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

On Mon, Aug 18, 2014 at 07:31:02PM +0000, Paul Barker wrote:
> On Mon, Aug 18, 2014 at 12:14:08PM -0700, Khem Raj wrote:
> > On Mon, Aug 18, 2014 at 12:08 PM, Paul Barker <paul@paulbarker.me.uk> wrote:
> > >> That would be handy too. But I wanted was to keep this info in project
> > >> for folks to try it out.
> > >>
> > >
> > > I'll just post one ticket for now.
> > >
> > 
> > Thats fine too.
> > 
> > > I think I've got a fix for e2fsprogs as well.
> > 
> > Great. when we write patches that arise out of musl systems we should
> > make sure that
> > 
> > 1. If patch fixes a genuine issue surfaced with musl, fight it out ar
> > respective package upstream and in OE universe add it to the original
> > layer where recipe primarily resides
> > but we can keep the patches in meta-musl as a last resort.
> > 
> > 2. If its something musl specific then lets keep it in meta-musl and
> > see how musl can be changed to fix it.
> > 
> > Thanks
> > -Khem
> 
> That makes sense. I'd suggest adding that to the README file in meta-musl so
> other would-be-contributors notice it.
> 
> In this case, it's ensuring that 'uint64_t' is used instead of '__uint64_t' and
> that <limits.h> is included where needed for 'PATH_MAX'. So I'd say those fixes
> belong in oe-core and are candidates for submitting upstream.
> 

Actually, both of these are fixed upstream already, but not as isolated commits
I can backport. There is a newer upstream release (v1.42.11) but it doesn't
contain the necessary fixes. It appears that the missing <limits.h> inclusion is
in a file added by patches in openembedded-core.

I shan't attempt the upgrade as there are a lot of patches in openembedded-core
to consider. I will try to make an isolated fix for the build issues with musl
though.

Cheers,

-- 
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

[-- Attachment #2: Type: application/pgp-signature, Size: 484 bytes --]

  reply	other threads:[~2014-08-18 19:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-17  0:50 Announcing meta-musl OE/Yocto layer supporting musl C library Khem Raj
2014-08-17 11:50 ` Diego Sueiro
2014-08-17 11:50   ` [OE-core] " Diego Sueiro
2014-08-17 11:50   ` Diego Sueiro
2014-08-17 12:36 ` atulkumar singh
2014-08-17 12:36   ` [OE-core] " atulkumar singh
2014-08-18 18:14 ` Paul Barker
2014-08-18 18:14   ` [OE-core] " Paul Barker
2014-08-18 18:26   ` Khem Raj
2014-08-18 18:26     ` [OE-core] " Khem Raj
2014-08-18 18:50     ` Paul Barker
2014-08-18 18:50       ` [OE-core] " Paul Barker
2014-08-18 19:04       ` Khem Raj
2014-08-18 19:04         ` [OE-core] " Khem Raj
2014-08-18 19:08         ` Paul Barker
2014-08-18 19:08           ` [OE-core] " Paul Barker
2014-08-18 19:14           ` Khem Raj
2014-08-18 19:14             ` [OE-core] " Khem Raj
2014-08-18 19:31             ` Paul Barker
2014-08-18 19:31               ` [OE-core] " Paul Barker
2014-08-18 19:54               ` Paul Barker [this message]
2014-08-18 19:54                 ` Paul Barker
2014-08-18 20:17         ` [musl] " Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140818195408.GD7174@gmail.com \
    --to=paul@paulbarker.me.uk \
    --cc=Openembedded-devel@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.