From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v2 0/7] vf610: Add USB support
Date: Tue, 19 Aug 2014 08:14:23 +0800 [thread overview]
Message-ID: <20140819001422.GB2928@peterchendt> (raw)
In-Reply-To: <cover.1408391385.git.stefan@agner.ch>
On Mon, Aug 18, 2014 at 10:07:10PM +0200, Stefan Agner wrote:
> This patchset adds USB support for Vybrid VF610 SoC. It extends the
> clock framework to support the USB PHY cocks, extends the device
> tree files and adds support for the non-core registers in the
> usbmisc_imx driver.
>
> This patchset needs the eSDHC registers length fix available in
> Shawn's for-next branch, since that overlapped by chance the USB
> areas.
>
> The whole patchset proved to be working on a Colibri VF61 and
> Freescale Tower VF65GS10. The first USB controller runs in
> peripheral mode. I could successfully use RNDIS, however with some
> stability issues: Suddenly the other side was not reachable anymore
> and the interface needed to brought down and back up again. I'm
> still investigating this.
>
> The second USB controller, running in USB host mode, showed errors
> when connecting devices behind a USB hub:
>
> [ 215.163507] usb usb1-port1: cannot reset (err = -32)
> [ 215.170498] usb usb1-port1: cannot reset (err = -32)
> [ 215.185120] usb usb1-port1: cannot reset (err = -32)
> [ 215.191345] usb usb1-port1: cannot reset (err = -32)
> [ 215.202487] usb usb1-port1: cannot reset (err = -32)
> [ 215.207718] usb usb1-port1: Cannot enable. Maybe the USB cable is bad?
> [ 215.219317] usb usb1-port1: unable to enumerate USB device
>
> By extending the PHY driver with the MXS_PHY_NEED_IP_FIX flag, this
> issue is resolved.
>
> Resend, also added Felipe Balbi this time, sorry about that. I think
> I only miss the Ack/Review from you here and then things should be
> fine.
>
> Changes in v2:
> - Extended usbmisc_imx to support multiple instances
> - Update DT documentation and compatible strings where necessary
> - Add USB PHY flag MXS_PHY_NEED_IP_FIX
> - Added patches to enable USB on Tower
>
> Stefan Agner (7):
> ARM: dts: vf610: Add USB PHY and controller
> ARM: imx: clk-vf610: Add USBPHY clocks
> usb: phy: mxs: Add VF610 USB PHY support
> ARM: dts: vf610: Add usbmisc for non-core registers
> chipidea: usbmisc_imx: Add USB support for VF610 SoCs
This driver change is already at my tree, but it is too late
for 3.17-rc1 when you sent, so I sent it to greg for v3.18.
Peter
> ARM: dts: vf610-colibri: Add USB support
> ARM: dts: vf610-twr: Add USB support
>
> Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 +
> .../devicetree/bindings/usb/usbmisc-imx.txt | 1 +
> arch/arm/boot/dts/vf610-colibri.dts | 10 ++++
> arch/arm/boot/dts/vf610-twr.dts | 10 ++++
> arch/arm/boot/dts/vf610.dtsi | 60 ++++++++++++++++++++--
> arch/arm/mach-imx/clk-vf610.c | 12 ++++-
> drivers/usb/chipidea/ci_hdrc_imx.c | 8 +++
> drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
> drivers/usb/chipidea/usbmisc_imx.c | 52 +++++++++++++++----
> drivers/usb/phy/phy-mxs-usb.c | 6 +++
> include/dt-bindings/clock/vf610-clock.h | 5 +-
> 11 files changed, 149 insertions(+), 17 deletions(-)
>
> --
> 2.0.4
>
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <peter.chen@freescale.com>
To: Stefan Agner <stefan@agner.ch>
Cc: <s.hauer@pengutronix.de>, <kernel@pengutronix.de>,
<shawn.guo@freescale.com>, <balbi@ti.com>,
<gregkh@linuxfoundation.org>, <jingchang.lu@freescale.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v2 0/7] vf610: Add USB support
Date: Tue, 19 Aug 2014 08:14:23 +0800 [thread overview]
Message-ID: <20140819001422.GB2928@peterchendt> (raw)
In-Reply-To: <cover.1408391385.git.stefan@agner.ch>
On Mon, Aug 18, 2014 at 10:07:10PM +0200, Stefan Agner wrote:
> This patchset adds USB support for Vybrid VF610 SoC. It extends the
> clock framework to support the USB PHY cocks, extends the device
> tree files and adds support for the non-core registers in the
> usbmisc_imx driver.
>
> This patchset needs the eSDHC registers length fix available in
> Shawn's for-next branch, since that overlapped by chance the USB
> areas.
>
> The whole patchset proved to be working on a Colibri VF61 and
> Freescale Tower VF65GS10. The first USB controller runs in
> peripheral mode. I could successfully use RNDIS, however with some
> stability issues: Suddenly the other side was not reachable anymore
> and the interface needed to brought down and back up again. I'm
> still investigating this.
>
> The second USB controller, running in USB host mode, showed errors
> when connecting devices behind a USB hub:
>
> [ 215.163507] usb usb1-port1: cannot reset (err = -32)
> [ 215.170498] usb usb1-port1: cannot reset (err = -32)
> [ 215.185120] usb usb1-port1: cannot reset (err = -32)
> [ 215.191345] usb usb1-port1: cannot reset (err = -32)
> [ 215.202487] usb usb1-port1: cannot reset (err = -32)
> [ 215.207718] usb usb1-port1: Cannot enable. Maybe the USB cable is bad?
> [ 215.219317] usb usb1-port1: unable to enumerate USB device
>
> By extending the PHY driver with the MXS_PHY_NEED_IP_FIX flag, this
> issue is resolved.
>
> Resend, also added Felipe Balbi this time, sorry about that. I think
> I only miss the Ack/Review from you here and then things should be
> fine.
>
> Changes in v2:
> - Extended usbmisc_imx to support multiple instances
> - Update DT documentation and compatible strings where necessary
> - Add USB PHY flag MXS_PHY_NEED_IP_FIX
> - Added patches to enable USB on Tower
>
> Stefan Agner (7):
> ARM: dts: vf610: Add USB PHY and controller
> ARM: imx: clk-vf610: Add USBPHY clocks
> usb: phy: mxs: Add VF610 USB PHY support
> ARM: dts: vf610: Add usbmisc for non-core registers
> chipidea: usbmisc_imx: Add USB support for VF610 SoCs
This driver change is already at my tree, but it is too late
for 3.17-rc1 when you sent, so I sent it to greg for v3.18.
Peter
> ARM: dts: vf610-colibri: Add USB support
> ARM: dts: vf610-twr: Add USB support
>
> Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 +
> .../devicetree/bindings/usb/usbmisc-imx.txt | 1 +
> arch/arm/boot/dts/vf610-colibri.dts | 10 ++++
> arch/arm/boot/dts/vf610-twr.dts | 10 ++++
> arch/arm/boot/dts/vf610.dtsi | 60 ++++++++++++++++++++--
> arch/arm/mach-imx/clk-vf610.c | 12 ++++-
> drivers/usb/chipidea/ci_hdrc_imx.c | 8 +++
> drivers/usb/chipidea/ci_hdrc_imx.h | 1 +
> drivers/usb/chipidea/usbmisc_imx.c | 52 +++++++++++++++----
> drivers/usb/phy/phy-mxs-usb.c | 6 +++
> include/dt-bindings/clock/vf610-clock.h | 5 +-
> 11 files changed, 149 insertions(+), 17 deletions(-)
>
> --
> 2.0.4
>
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2014-08-19 0:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 20:07 [PATCH RESEND v2 0/7] vf610: Add USB support Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 1/7] ARM: dts: vf610: Add USB PHY and controller Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 2/7] ARM: imx: clk-vf610: Add USBPHY clocks Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 3/7] usb: phy: mxs: Add VF610 USB PHY support Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-09-01 13:06 ` Stefan Agner
2014-09-01 13:06 ` Stefan Agner
2014-09-03 20:13 ` Felipe Balbi
2014-09-03 20:13 ` Felipe Balbi
2014-08-18 20:07 ` [PATCH RESEND v2 4/7] ARM: dts: vf610: Add usbmisc for non-core registers Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 5/7] chipidea: usbmisc_imx: Add USB support for VF610 SoCs Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 6/7] ARM: dts: vf610-colibri: Add USB support Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:07 ` [PATCH RESEND v2 7/7] ARM: dts: vf610-twr: " Stefan Agner
2014-08-18 20:07 ` Stefan Agner
2014-08-18 20:24 ` Sergei Shtylyov
2014-08-18 20:24 ` Sergei Shtylyov
2014-08-22 7:47 ` Shawn Guo
2014-08-22 7:47 ` Shawn Guo
2014-08-19 0:14 ` Peter Chen [this message]
2014-08-19 0:14 ` [PATCH RESEND v2 0/7] vf610: " Peter Chen
2014-08-22 8:07 ` Shawn Guo
2014-08-22 8:07 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819001422.GB2928@peterchendt \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.